Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative tickInterval renders the webpage unresponsive #12961

Closed
KrishnaKumarHariprasannan opened this issue Feb 14, 2020 · 5 comments · Fixed by #16263
Closed

Negative tickInterval renders the webpage unresponsive #12961

KrishnaKumarHariprasannan opened this issue Feb 14, 2020 · 5 comments · Fixed by #16263

Comments

@KrishnaKumarHariprasannan
Copy link
Contributor

Expected behaviour

Validate values passed as tickInterval

Actual behaviour

Passing negative values makes the webpage continuously increase it's memory footprint and slows down the browser

Live demo with steps to reproduce

https://jsfiddle.net/uhfw2gzx/

Product version

8.0.0

Affected browser(s)

Chrome, Firefox

@sebastianbochan
Copy link
Contributor

Hi @KrishnaKumarHariprasannan,
Thank you for reporting about the problem. Im not sure if its a bug because the tickInterval should have the positive or undefined value.

@TorsteinHonsi should we consider it as a bug? Maybe we should only update our docs and add the information that the tickInterval has to be positive?

@KrishnaKumarHariprasannan
Copy link
Contributor Author

Thanks for your response @sebastianbochan! I brought this up only because of the enormous load this bug puts on the webpage's compute and memory footprint. I do agree that for something as innocuous as say yAxis.lineWidth = -10, a note on the docs would be sufficient.

@mlucool
Copy link

mlucool commented Feb 14, 2020

Given the strain on the page (it crashes the browser sometimes), it feels like a validation should throw error rather than document that users should avoid passing this.

@circleci-mu circleci-mu added this to To do in Development-Flow Mar 5, 2020
@stale
Copy link

stale bot commented Aug 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the Status: Stale This issue hasn't had any activity for a while, and will be auto-closed if no further updates occur. label Aug 22, 2021
@raf18seb raf18seb added Type: Bug Type: Good for beginners and removed Status: Stale This issue hasn't had any activity for a while, and will be auto-closed if no further updates occur. Type: Undecided labels Aug 23, 2021
@raf18seb
Copy link
Contributor

raf18seb commented Aug 23, 2021

I agree with @mlucool, we can add some information to the docs that the negative tickInterval is not being taken into account and add an error handler, something like:

var ...,
tickIntervalOption = isNumber(options.tickInterval) && options.tickInterval >= 0 ? options.tickInterval : undefined,
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants