Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect focus outline for rotated data labels in Word Cloud #15973

Closed
franklinefrancis opened this issue Jun 29, 2021 · 4 comments · Fixed by #15977
Closed

Incorrect focus outline for rotated data labels in Word Cloud #15973

franklinefrancis opened this issue Jun 29, 2021 · 4 comments · Fixed by #15977
Assignees
Labels
a11y Accessibility related. Type: Bug

Comments

@franklinefrancis
Copy link

franklinefrancis commented Jun 29, 2021

Expected behaviour

Focus outline of rotated data labels in word cloud should not overlap with the data label themselves

Actual behaviour

Focus outline is inconsistent for rotated data labels

Rotated Word Cloud

Live demo with steps to reproduce

https://jsfiddle.net/franklinefrancis/La609cs2/

Product version

8.2.0

Affected browser(s)

Firefox

@highsoft-bot highsoft-bot added this to To do in Development-Flow Jun 29, 2021
@franklinefrancis franklinefrancis changed the title Incorrect focus outline for rotated data points in Word Cloud Incorrect focus outline for rotated data labels in Word Cloud Jun 29, 2021
@raf18seb
Copy link
Contributor

Hi @franklinefrancis, thanks for creating the ticket.

Could you provide the exact steps to reproduce that issue? I was focusing on each word one by one and I haven't seen any issues (I tested in 8.2.0 and the newest 9.1.2). Thanks in advance.

@khlieng
Copy link
Member

khlieng commented Jun 29, 2021

@raf18seb did you try it in Firefox? 8.2.0, 9.1.2 and master all had the same problem for me.

@franklinefrancis
Copy link
Author

franklinefrancis commented Jun 30, 2021

@raf18seb,

This issue was seen only in Firefox. Here is the screen recording:

Rotated word cloud

And here are the steps:

  1. Open the JSFiddle link in Firefox
  2. Start tabbing from the first input field
  3. Once Wordcloud is in focus, use arrow keys to see the focus outline
  4. Notice that for a few data labels the focus outline overlaps with the data label

@raf18seb
Copy link
Contributor

You are right, it's a Firefox issue - I was testing on Chrome. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility related. Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants