Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus in not getting back to menu context once clicked on escape button from full screen. #16339

Closed
SreejaPampara opened this issue Sep 14, 2021 · 16 comments · Fixed by #16892
Closed
Assignees
Labels

Comments

@SreejaPampara
Copy link

Expected behaviour

With Maintaining Focus the Menu button should also opened when clicked enter Once clicked on escape button from full screen.

Actual behaviour

Highlighting the Menu button but focus is somewhere else, and the menu button is not getting opened by clicking enter button once coming back by clicking escape button from full screen.
Observed both for Graphs and pie Chart.

Live demo with steps to reproduce

https://jsfiddle.net/SreejaPampara/hj7x3w2q/1/

Product version

HighCharts version : v9.2.2

Affected browser(s)

Chrome, Edge

@highsoft-bot highsoft-bot added this to To do in Development-Flow Sep 14, 2021
@raf18seb
Copy link
Contributor

Hi @SreejaPampara,

Exiting from the full screen by the escape button click is a default browser action - it's not coming from the Highcharts library.

You can add the possibility to open fullscreen on the enter button click e.g. this way (very simple example): https://jsfiddle.net/BlackLabel/j5uar1vx/

I'm tagging this ticket as a feature request, please vote for it by adding a thumb up 👍

@raf18seb raf18seb added the Type: Feature Request Used when a new feature is requested either directly or indirectly label Sep 15, 2021
@SreejaPampara
Copy link
Author

SreejaPampara commented Sep 16, 2021

Hi @raf18seb is it possible access the menu icon with enter button after returning from full screen, currently even though it is showing as the focus is at the menu icon but no action is triggering after clicking on the enter button as it is causing a accessibility issue. Attaching the screenshots for reference.
image

  • As in full screen also it is taking additional tab to go to menu.

image

@raf18seb
Copy link
Contributor

raf18seb commented Sep 16, 2021

Hi @SreejaPampara,

I think I misunderstood you in the first post.
This could be improved - the exporting button is focused after exiting the fullscreen, but the exporting menu is not being opened when clicking enter. It's working fine before entering the fullscreen and it's working fine after exiting the fullscreen but pressing the additional tab button is required.

@raf18seb raf18seb added a11y Accessibility related. Type: Bug and removed Type: Feature Request Used when a new feature is requested either directly or indirectly labels Sep 16, 2021
@SreejaPampara
Copy link
Author

Hi @raf18seb ,
Please let us know if there is any update on the above issue, any new version are you planning to release in which this issue is fixed?

@raf18seb
Copy link
Contributor

raf18seb commented Oct 19, 2021

@SreejaPampara for now we don't have ETA for the bugfix. We will discuss it at the next meeting.

@oysteinmoseng do you have any insights (accessibility)?

@oysteinmoseng
Copy link
Member

Hi, yes I believe this is a bug and can be improved. The Highcharts visual focus indicator is not updated when entering/exiting fullscreen. We should explicitly set focus to the menu as suggested.

@SreejaPampara
Copy link
Author

Hi @raf18seb,
Would you please let us know by when this bug can be closed or provide an ETA which would be helpful for us as it is effecting our compliance.

@KacperMadej
Copy link

This bug will be further investigated and we should have more info around 8.11. This is quite a long wait, so in the meantime would you be interested in a temporary workaround that you could test and use before the proper fix will be implemented and released? @SreejaPampara

@SreejaPampara
Copy link
Author

@KacperMadej, Yes, please provide the alternative. We will try it with that from our end.

@KacperMadej
Copy link

https://jsfiddle.net/BlackLabel/j5uar1vx/2/

After tabbing into the export menu and pressing enter to open the full-screen mode the old highlight border will be removed.
The export menu is then closed and after 1 tab could be selected again. After that, you could open it and exit the full-screen mode by selecting the related option listed there or simply via the escape key at any time after opening the full-screen mode.

Please let me know if this works for you as a workaround for now and if not, how could it be improved.

@SreejaPampara
Copy link
Author

SreejaPampara commented Nov 5, 2021

Hi @KacperMadej,
Yes. Thank you for the response. Could you please let me know for this workaround, any code changes need to be done from our end, or else the existing version of this will be included with this workaround.
Please mention what code changes need to be done from our end, if necessary for this workaround

@raf18seb
Copy link
Contributor

raf18seb commented Nov 8, 2021

@SreejaPampara, is the workaround provided by @KacperMadej working fine for you? if not, could you tell us what could be improved?
https://jsfiddle.net/BlackLabel/j5uar1vx/2/

@vaishnavi-115
Copy link

vaishnavi-115 commented Jan 13, 2022

Hi @KacperMadej
The temporary fix suggested was not sufficient for the testing team. They have also checked with their SME on this. Please suggest a code fix or another work around for this issue.
It would be helpful if we can get an estimated date, by which this issue will be fixed.
Furthermore, as this issue is a priority to us, please let us know when we can have a call to discuss it.

@oysteinmoseng
Copy link
Member

@vaishnavi-115 I will take a look at this issue as soon as possible and provide a stable fix. Expect this to be resolved by early next week.

@vaishnavi-115
Copy link

As we know that HIGHCHART is NOT open source software.
Could you please give us the details about which Microsoft team owns it currently.
Thank you.

@oysteinmoseng
Copy link
Member

Hi @vaishnavi-115, we can not share license information publicly on GitHub. Please get in touch with our sales team and they will be happy to assist you with any questions related to licensing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development-Flow
  
Review in progress
7 participants
@oysteinmoseng @KacperMadej @raf18seb @highsoft-bot @SreejaPampara @vaishnavi-115 and others