New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area chart displayed incorrect after zoom/unzoom HC - 3.0 #1651

Closed
sebastianbochan opened this Issue Mar 28, 2013 · 23 comments

Comments

Projects
None yet
6 participants
@sebastianbochan
Contributor

sebastianbochan commented Mar 28, 2013

Area chart is not displayed correctly, after zooming and click "all button"

To reproduce

  1. http://jsfiddle.net/5S9X7/1/
  2. zoom by select range (i.e by mouse)
  3. click "all" button
  4. Area chart looks like weird.

HC 3.0

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Apr 2, 2013

Another manifestation of the same problem:

  1. http://jsfiddle.net/highcharts/qgprf/
  2. Click the "All" button
@sebastianbochan

This comment has been minimized.

Contributor

sebastianbochan commented Apr 5, 2013

In this examples http://jsfiddle.net/qrbzg/4/ / http://jsfiddle.net/Bmbrd/ problem also appears, but with the newest master release, I came across error in translate function.

@pawelfus

This comment has been minimized.

Contributor

pawelfus commented Apr 5, 2013

It's almost fully fixed, another example: http://jsfiddle.net/qrbzg/6/

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Apr 8, 2013

Seems like a workaround for that case is to not use the index option, but
instead apply the series in the wanted order.

@fpinta

This comment has been minimized.

fpinta commented Apr 8, 2013

I apply the difference shown in the fixing #1651 but the results is already bad.

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Apr 9, 2013

@fpinta: Demo?

@pawelfus

This comment has been minimized.

Contributor

pawelfus commented Aug 19, 2013

Example: http://jsfiddle.net/ka4sc/

Click 'All' to get wrong rendered series (right side) - path is duplicated in DOM, in version 1.3.2 works properly.

@anber500

This comment has been minimized.

anber500 commented Sep 26, 2013

We've developed a software application for a big client of ours and have been sitting with this bug for over 3 months. I'm using highstock for the charting of financial data. Naturally the data sets can get very big.

Our application is close to launch and is currently in the second TC. Our client is getting very nervous that this bug may not be solved in time and frankly so am I. Considering that this bug has been around for the last few iterations, it's getting me a little worried.

Can we please get a priority on this defect?
Details here:
http://stackoverflow.com/questions/18117970/in-highstock-1-3-0-when-zooming-in-full-the-graph-draws-all-messed-up/18125374?noredirect=1#comment28110929_18125374

issue

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Sep 27, 2013

We'll give this top priority. The issue started with e49d9e0, which is a merge commit so we'll have to dig in there.

TorsteinHonsi added a commit that referenced this issue Sep 27, 2013

Fixed Highstock issue with stacks not being properly cleared when mov…
…ing between non-grouped and grouped data, leaving artefacts in a stacked area chart. Closes #1651.
@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Sep 27, 2013

Sorry you'd have to wait so long, please see the provided fix above. My recommendation is that you apply this patch to Highstock 1.3.5 then compile it at http://closure-compiler.appspot.com/home. If you have any problems with it, report back here and we'll follow up.

@anber500

This comment has been minimized.

anber500 commented Sep 27, 2013

Thanks for the reply. I'll test it asap.

@anber500

This comment has been minimized.

anber500 commented Sep 27, 2013

It seems like it's fixed now :)
Thank you so much. Our testers will continue trying to break it and I'll report back once the TC is complete.

TorsteinHonsi added a commit that referenced this issue Oct 8, 2013

@anber500

This comment has been minimized.

anber500 commented Oct 8, 2013

Our TC is nearing completion. One of our testers send us a screenshot. It seem like this defect is related. The version of the charts they were testing on has the patch applied. In most cases, the patch worked. It seems like there could still be cases where the issues pops up.

4

@anber500

This comment has been minimized.

anber500 commented Oct 9, 2013

I can confirm that I've been able to reproduce this. Another problem (probably unrelated) seems to be that as the scale of the graph changes, the bottom axis changes position when the chart redraws.

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Oct 9, 2013

Please share a live demo so that we can be able to reproduce it also. Without a reproduction we can't locate the bug.

@anber500

This comment has been minimized.

anber500 commented Oct 14, 2013

I have been testing with version 1.3.6. It seems like it's fixed in that version. We didn’t want to upgrade because we're too far into testing to change libraries now. It's too risky but it seems like we have no option on this.

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Oct 16, 2013

You should be able to take your existing version and apply only the diffs
from the commits related to this issue.

@anber500

This comment has been minimized.

anber500 commented Oct 17, 2013

I did apply only the diffs as suggested and it did fix my immediate problem but similar defects started popping up. The code in 1.3.6 is slightly different than the code in the diffs.

I got the upgrade approved and we are rolling out with 1.3.6. It's risky but the new version did fix a bunch of problems we were having. Compliments to your devs.

@anber500

This comment has been minimized.

anber500 commented Oct 29, 2013

The problem is still happening. I tested with version 1.3.7 and it's still there. Our application is in closed beta and this issue is still popping up.

Here is a fiddle to illustrate the problem:
http://jsfiddle.net/j8uM6/

Just grab the bottom handle on the navigator and drag it around. After a couple of drags, the whole thing goes weird.

It's using this version:
Highstock JS v1.3.7 (2013-10-24)

updates

...and an image from our tester who is on version 1.3.6 + (patch from another bugfix):
17 png_500x500

Please can we have this prioritised as we have completed our final TC on Friday? (If fixed, will this only require a regression test?)

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Oct 29, 2013

Simplified: http://jsfiddle.net/highcharts/StF7z/
Note: It's a different issue though it looks the same - the reason seems to be that the ordinal xAxis.getGroupIntervalFactor returns two diffferent values, causing the data grouping to be different for the two series. Data grouping should always be the same.

@anber500

This comment has been minimized.

anber500 commented Oct 30, 2013

Not sure I follow. Are you saying that it's something we need to fix? What are we doing wrong?

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Oct 30, 2013

Sorry for the confusion, it's something we need to fix. I added the new issue at #2416.

@hansliebenberg

This comment has been minimized.

hansliebenberg commented Nov 7, 2013

Hi,

Is there a time ETA on this fix? We have a system going into production next week and this one of our 2 bugs (both highstock related) left.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment