-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defining a legend.labelFormatter function breaks legend keyboard navigation #16818
Comments
Hi @longmatthewh, thank you for creating the ticket! Seems like a duplicate of #16467, but let @oysteinmoseng confirm/decide. |
Same issue, adding a more robust fix. |
Awesome! Thanks @raf18seb and @oysteinmoseng ! Any idea when we'd expect this to make a release? |
@longmatthewh It should be part of the next release, and while we don't have a set date for that yet, I would expect a few weeks after New Years. Does that work okay for you? |
@raf18seb yeah, that's fine, thanks. I've got a workaround for what I'm trying to do, but when this change rolls out, I'll definitely take advantage since it'll make our code simpler. |
@raf18seb has this been released yet? |
@longmatthewh Sorry about the late update! The previous release was a hotfix release for a specific high-impact issue only, but this fix will be part of v10 coming out in a week or 2. Is this okay for you? |
(cc: @sgupta-deque) thanks for the reply @oysteinmoseng. The sooner we can use labelFormatter and not break keyboard navigation, the better. The workaround we're using should be fine for now. While, a week or 2 for this fix will probably be too late to make it into our release, it is something we'll absolutely need in future releases, though. |
Expected behaviour
I'd like to be able to utilize
legend.labelFormatter
to customize the format of the legend labels, and maintain keyboard functionality in the legend—arrow keys to navigate between series and spacebar/return/enter to toggle each series.Actual behaviour
Upon defining a formatter function—it doesn't matter how complex the function is—expected keyboard functionality in the legend is broken.
...I'm no longer able to use the arrow keys to navigate between series or the spacebar to toggle visibilty.
Live demo with steps to reproduce
https://jsfiddle.net/longmatthewh/qby4k80g/16/
Product version
Highcharts JS v9.3.2 w/ the Accessibility module
Affected browser(s)
At least Chrome
The text was updated successfully, but these errors were encountered: