Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definitions for PieSeries not public #17551

Closed
dfenerski opened this issue Aug 1, 2022 · 6 comments
Closed

Type definitions for PieSeries not public #17551

dfenerski opened this issue Aug 1, 2022 · 6 comments
Assignees
Labels
Type: Feature Request Used when a new feature is requested either directly or indirectly

Comments

@dfenerski
Copy link

dfenerski commented Aug 1, 2022

Expected behaviour

To be able to see and use these, a common use case is to call a method from a predefined series; in the docs there are many examples with this.

Actual behaviour

seriesTypes, PieSeries are not public

Am I missing something? It would be great to have these.

Thanks for the info in advance!

You can vote for this feature by adding a thumbs-up reaction to this post.

@raf18seb
Copy link
Contributor

raf18seb commented Aug 2, 2022

Hi @dfenerski, could you provide more details? I think you forgot to attach something. Especially this sentence is very unclear:

To be able to see and use these

@dfenerski
Copy link
Author

image
There is nothing to import from highcharts with regards to seriesTypes or the PieSeries. In the official docs, there is a mappie example chart, whose renderer calls the pie one. Without access to the typedefs of those, one has to to what I did in the pic.

@raf18seb raf18seb added Type: Feature Request Used when a new feature is requested either directly or indirectly and removed Status: Pending reply labels Aug 3, 2022
@raf18seb
Copy link
Contributor

raf18seb commented Aug 3, 2022

Thank you for clarifying! I added the feature request tag.

ps. mappie demo is no longer supported and removed from our docs, see changelog and series-on-point feature: mappie demo

@dfenerski
Copy link
Author

dfenerski commented Aug 5, 2022

Out of curiosity, why did support got dropped for the mappie and what do you mean by this? Is it just removed from the docs or is the official sample no longer working and discouraged from using? Because I've noticed after v9.2 it breaks..

I think without types for seriesTypes, chart type extension is more cumbersome in general, not only for a deprecated mappie and this IMO is critical.

@raf18seb
Copy link
Contributor

raf18seb commented Aug 8, 2022

I think without types for seriesTypes, chart type extension is more cumbersome in general, not only for a deprecated mappie and this IMO is critical.

@bre1470 seriesTypes is deprecated, isn't it?
Should new series be created using class and registerSeriesType()?
Like this: https://jsfiddle.net/BlackLabel/fwcLatyj/

Out of curiosity, why did support got dropped for the mappie? and what do you mean by this

Maybe I wasn't clear enough, sorry for that. We still support mappie demo, but we added a new feature "Series on point" so now it's easier to create a demo with pies on the map without creating a new series type.

Is it just removed from the docs or is the official sample no longer working and discouraged from using?

The demo has been replaced and we encourage using a new "Series on point" feature. However, the old demo should work correctly as well.

@bre1470 bre1470 self-assigned this Aug 9, 2022
@bre1470
Copy link
Member

bre1470 commented Aug 9, 2022

@raf18seb Yes, it is deprecated. Your example looks correct for the current situation, though this should not be something official or as a workaround.

@dfenerski
We will add Series.types and Series.registerType with the next release. Highcharts.seriesTypes and Highcharts.seriesType will be kept for backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request Used when a new feature is requested either directly or indirectly
Projects
None yet
Development

No branches or pull requests

3 participants