Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data label disappears on hover #17957

Closed
kluvin opened this issue Nov 9, 2022 · 3 comments · Fixed by #17964
Closed

Data label disappears on hover #17957

kluvin opened this issue Nov 9, 2022 · 3 comments · Fixed by #17964

Comments

@kluvin
Copy link

kluvin commented Nov 9, 2022

Expected behaviour

Data label persist on hover

Actual behaviour

Data label disappears on hover

Live demo with steps to reproduce

https://jsfiddle.net/qhwz90nL/

Removing off the marker.enabled: false bit, the issue is resolved.
https://jsfiddle.net/qhwz90nL/1/

Product version

Presumably originating in the Accessibility module.
Introduced in 10.3.0 and seen in later versions

Affected browser(s)

FF, Chrome

@karolkolodziej
Copy link
Contributor

Hi @kluvin and thank you for reporting that issue!

Internal note:
Bisected to commit: ac1f55b
FYI @TorsteinHonsi

@TorsteinHonsi
Copy link
Collaborator

Ouch. We should prioritize this. @karolkolodziej will you have a look? We need to figure out what series.options.inactiveOtherPoints has to do with this and why the offending commit broke it.

@TorsteinHonsi
Copy link
Collaborator

TorsteinHonsi commented Nov 10, 2022

@karolkolodziej I just tried re-adding this:

                if (
                    series.options.inactiveOtherPoints &&
                    isNumber(opacity)
                ) {
                

Actually I can't see any consequence on the map that I was testing when removing the inactiveOtherPoints check. So I suggest just adding that condition back to what it was, and making sure we have a regression test for #17957.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants