highcharts.d.ts is 603000 lines long and freezes editors

[rbirkgit]

Expected behaviour

I expect type file to be split in smaller files and more manageable. It is over 603000 lines long and took me all night to index in IntelliJ and still afterwards my machine is basically down.

Actual behaviour

Split to smaller type files

Live demo with steps to reproduce

Product version

11.0.1

Affected browser(s)

[TorsteinHonsi]

Thanks for reporting! FYI @bre1470

[zernie]

This issue totally breaks auto-complete and type-checking :(

[rbirkgit]

It makes it really hard to work with Highcharts and I tend to avoid it just for this reason. Hopefully this can be fixed.

[karolkolodziej]

Hi @rbirkgit!
Thank you for bringing our attention to this! We are investigating this issue and we are looking into possible solutions!
We will keep you posted!

[oleksandr-honcharov-simpligov]

Thanks for your fix.
However, the problem still exists until the fix is released.
When are you planning to release a new version?

[karolkolodziej]

Hi @oleksandr-honcharov-simpligov!
Correct it hasn't been released yet and we haven't talked about the release but we will keep you posted.
If you would like to test it now you can use our guide and create your own bundle from the master branch.

[rbirkgit]

I LOVE 11.4.1 and the new type files. It's lightning fast now!

[trinhngocdiep]

From 11.4.0 to 11.4.1 is a breaking change, not a minor / bugfix release as indicated by the version number.

This was valid in 11.4.0:

const options: Highcharts.SeriesLineOptions = ...

In 11.4.1 typescript is reporting this error:
"node_modules/highcharts/highcharts" has no exported member named 'SeriesLineOptions'. Did you mean 'SeriesSplineOptions'?ts(2724)

I then have to update the import to fix this:

import { SeriesLineOptions } from 'highcharts';

[bre1470]

Hello, @trinhngocdiep!
Thank you for the feedback. Your issue cannot be replicated.
Please take a look at https://github.com/bre1470/testproject-es6 for a working setup to compare.
You can change there the tsconfig.json to CommonJS and use non-ES6 imports like yours as well.
If your issue remains, please create a new issue with your tsconfig.json and ideally some demonstration code.

[pietmichal]

This should've been considered a breaking change.

[karolkolodziej]

@pietmichal Could you please elaborate on what should be considered a breaking change?
Can you recreate that so we can test it?