Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Enhancement) Please add source maps for minified code #1902

Closed
kenaniah opened this issue May 30, 2013 · 12 comments
Closed

(Enhancement) Please add source maps for minified code #1902

kenaniah opened this issue May 30, 2013 · 12 comments
Assignees

Comments

@kenaniah
Copy link

@kenaniah kenaniah commented May 30, 2013

http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/ gives a quick overview for the uninitiated.

Essentially, usage of source maps should aid in the debugging efforts of production code as one would no longer have to switch back to highcharts.src.js just to track down errors.

@dspnorman
Copy link

@dspnorman dspnorman commented Mar 11, 2015

I'd like to add my support for this enhancement. Given that the issue has been open for nearly two years, I'm not optimistic, but hey, maybe it just got lost in the shuffle?

Auto generating a sourcemap for the minified code should be as simple as passing a flag to Closure Compiler...

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Mar 12, 2015

To add it to code.highcharts.com and our zip packages we should

  • Pass the flag to Closure Compiler in the compile target.
  • For that we would need names for the map files, added in the minify target.
  • In the dist target, copy the files over to distribution folders.
@Tomcat-Engineering
Copy link

@Tomcat-Engineering Tomcat-Engineering commented May 27, 2016

+1

1 similar comment
@jasonadt
Copy link

@jasonadt jasonadt commented Jun 22, 2017

+1

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Jun 22, 2017

We are working on this, in fact we are already uploading the maps to code.highcharts.com (http://code.highcharts.com/highcharts.js.map). What's left is to add the reference to the map from the minified files.

@e-cloud
Copy link

@e-cloud e-cloud commented Mar 2, 2018

sourcemap is still unavailable now. no reference added to the minified files.

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Mar 7, 2018

@jon-a-nygaard What's the status?

@olejorgenb
Copy link

@olejorgenb olejorgenb commented Apr 17, 2018

In the npm package we're using (6.0.6) there is source maps, but maybe that's added by a third party?

Unfortunately I haven't succeeded getting webpack to "forward" these maps so it's not much help :(

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Apr 26, 2018

@jon-a-nygaard Anything new?

@scott-ho
Copy link

@scott-ho scott-ho commented Sep 11, 2018

It's a 5.5 years issue. And no fix available. Does highcharts team take this seriously? For commercial users, that's really bad experience.

@jon-a-nygaard
Copy link
Contributor

@jon-a-nygaard jon-a-nygaard commented Sep 13, 2018

v6.1.3 is now published with fixed source maps which is detected by the browser.
Apologies for the delay.

@scott-ho
Copy link

@scott-ho scott-ho commented Sep 14, 2018

Thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.