Prototype adapter: error messages on point animation after points are destroyed #291

Closed
TorsteinHonsi opened this Issue Jul 4, 2011 · 1 comment

Projects

None yet

2 participants

@TorsteinHonsi
Collaborator

Steps to reproduce:

  1. Open http://jsfiddle.net/highcharts/EHQtk/ with Firefox and Firebug open.
  2. Before the columns are finished animating in, click Destroy
  3. Error messages keep logging in Firebug.

This bug is probably directly related to #290, or some closely related part of the events handling. Events on each point should be destroyed when the point is destroyed. Work on #290 first, then come back to this one.

@eolsson
Contributor
eolsson commented Aug 4, 2011

Notes:
In prototype-adapter line 124 a new effect is created for each attribute, it will then connect it self to the el._highcharts_animation property. This way, the last one is overwriting the handle to all previous animations on the same element. Also the fx local variable is just left dangling.

Later on in stop(), only the last one is canceled, leaving all other animations running on the destroyed chart. I think this is causing the error messages.

@eolsson eolsson added a commit that closed this issue Aug 9, 2011
@eolsson eolsson References to effects in prototype adapter are kept until they are fi…
…nished or canceled. Closes #291
fc5a59e
@eolsson eolsson closed this in fc5a59e Aug 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment