New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfall - update point not propagate to sum #3710

Closed
sebastianbochan opened this Issue Jan 8, 2015 · 11 comments

Comments

Projects
None yet
3 participants
@sebastianbochan
Contributor

sebastianbochan commented Jan 8, 2015

When we update any point, sum is not updated.
Example: http://jsfiddle.net/961uhu6h/21/

@ghost ghost closed this in 542f7b8 Jan 9, 2015

@olegnazarov23

This comment has been minimized.

olegnazarov23 commented Jan 9, 2015

Hello,

I noticed that it has been fixed! :)

There is a small bug came up after fixing the one we talked about. When you render the waterfall for the first time, the "Balance column (isSum)" has 0 value, but when you change other columns values, it recalculates it just fine.

Same goes for isIntermediateSum

Also, in this jsfiddle http://jsfiddle.net/961uhu6h/28/ if you click second button a few times, so the column will have a negative value, the column color doesn't change to negative value color. But if you go from negative value to positive - it works just fine.

Thanks!

@olegnazarov23

This comment has been minimized.

olegnazarov23 commented Jan 9, 2015

Also, there is another small bug, please use this jsfiddle - http://jsfiddle.net/961uhu6h/29/ Use 3rd button.

Onclick it changes the column value, and it should change the first label from "Name" to "New label", value changes fine, but the Label doesnt :(

TorsteinHonsi added a commit that referenced this issue Jan 15, 2015

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Jan 15, 2015

There is a small bug came up after fixing the one we talked about. When you render the waterfall for the first time, the "Balance column (isSum)" has 0 value, but when you change other columns values, it recalculates it just fine.

I'm not able to reproduce that at http://jsfiddle.net/highcharts/961uhu6h/33/. At first render, the sum shows 345k. What am I missing?

Also, in this jsfiddle http://jsfiddle.net/961uhu6h/28/ if you click second button a few times, so the column will have a negative value, the column color doesn't change to negative value color.

Confirmed. This is fixed now in e17951b.

Also, there is another small bug, please use this jsfiddle - http://jsfiddle.net/961uhu6h/29/ Use 3rd button.

I added this as a separate issue, see #3728

(Edit: Corrected first fiddle that pointed to my local files)

@olegnazarov23

This comment has been minimized.

olegnazarov23 commented Jan 15, 2015

hi,

Regarding the first render sum; did you use highcharts library after the very first bug was fixed? (very first message in this topic) Looks like right now you are using production version, where it works fine, but it doesnt re-render isSum and isIntermediateSum on value change. Can you please try to use version of highcharts where it was fixed (I downloaded it straight from github, that's why I didn't provide jsfiddle)

I hope I didn't confuse you :)

Let me please know if I need to explain more.

Thanks,
Oleg

@ghost

This comment has been minimized.

ghost commented Jan 16, 2015

This is the fiddle from the first post, with the latest github version: http://jsfiddle.net/stephanevanraes/961uhu6h/32/
Looks to me that it works

@olegnazarov23

This comment has been minimized.

olegnazarov23 commented Jan 16, 2015

Hi Stephane,

Yes you are right, it works on my end too. Weird. Sorry for misinformation

Thanks for your help,
Oleg

On Friday, January 16, 2015, Stephane Vanraes notifications@github.com
wrote:

This is the fiddle from the first post, with the latest github version:
http://jsfiddle.net/stephanevanraes/961uhu6h/32/
Looks to me that it works


Reply to this email directly or view it on GitHub
#3710 (comment)
.

@sebastianbochan

This comment has been minimized.

Contributor

sebastianbochan commented Mar 2, 2015

http://jsfiddle.net/5x6zvggo/

When the waterfall chart has 2+ isSum, it doesn't calculate them correctly.

2012 value should be 920 + 102 + 233 = 1255

@ghost

This comment has been minimized.

ghost commented Mar 3, 2015

@sebastianbochan according to the API : http://api.highcharts.com/highcharts#series.data.isIntermediateSum
... the points acts as a summary column for the values added or substracted since the last intermediate sum, or since the start of the series...
so 335 is correct (102 + 223)

@olegnazarov23

This comment has been minimized.

olegnazarov23 commented May 19, 2015

Hi Stephane,

I have a question, our client is financial firm, and they are
using parentheses () as an analog of negative value on the chart.

Basically value -53 could be also (53)

Is there any way that we can prepare data array for waterfall chart
using parentheses and highcharts will recognize that values as negatives?
And also on the chart instead of having -53 it will output (53)?

Thank you for your help,
Oleg

On Tue, Mar 3, 2015 at 2:03 AM, Stephane Vanraes notifications@github.com
wrote:

@sebastianbochan https://github.com/sebastianbochan according to the
API : http://api.highcharts.com/highcharts#series.data.isIntermediateSum
... the points acts as a summary column for the values added or
substracted since the last intermediate sum, or since the start of the
series...

so 335 is correct (102 + 223)


Reply to this email directly or view it on GitHub
#3710 (comment)
.

@ghost

This comment has been minimized.

ghost commented May 20, 2015

Hi,

To change the output you can use the formatter function: http://api.highcharts.com/highcharts#series.dataLabels.formatter

As for the input, Highcharts only accepts numbers (and null) as values in the data array, to have the parentheses you need the input strings which is not possible, therefore you will have to take the array with the strings and write a transformation function to change the notation.

@olegnazarov23

This comment has been minimized.

olegnazarov23 commented May 21, 2015

Thank you :)

On Wed, May 20, 2015 at 1:43 AM, Stephane Vanraes notifications@github.com
wrote:

Hi,

To change the output you can use the formatter function:
http://api.highcharts.com/highcharts#series.dataLabels.formatter

As for the input, Highcharts only accepts numbers (and null) as values
in the data array, to have the parentheses you need the input strings which
is not possible, therefore you will have to take the array with the strings
and write a transformation function to change the notation.


Reply to this email directly or view it on GitHub
#3710 (comment)
.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment