Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors in column chart with negativeColor don't change on dynamic data change until mouseover #4267

Closed
forty8bits opened this issue Jun 5, 2015 · 10 comments

Comments

@forty8bits
Copy link

commented Jun 5, 2015

See http://jsfiddle.net/ZujZ3/4/ for an example. To reproduce:

  1. Click on the Change Data button to change values.
  2. You'll notice that when new values cause the column to cross threshold the color doesn't change.
  3. Hover over the column(s) and the color should change to expected color.

Any known workarounds for the meantime?

@Jollyfant

This comment has been minimized.

Copy link

commented Jun 5, 2015

See this hacky workaround by triggering columns hover state.

http://jsfiddle.net/jq0bne8c/1/

Jolly

@TorsteinHonsi

This comment has been minimized.

Copy link
Collaborator

commented Aug 31, 2015

@pawelfus The fix doesn't work when applied to Highcharts 4.1.8... All columns become red after a while. Any idea?

@pawelfus

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2015

See #4430 - before that commit is used to work.

@TorsteinHonsi

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2015

Can you work out a fix that works with both cases?

@TorsteinHonsi

This comment has been minimized.

Copy link
Collaborator

commented Oct 15, 2015

@pawelfus Is this ready to be merged? There was a conflict with the updated master?

@pawelfus

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2015

Let me double check this. I am pretty sure I resolved that issue a while ago.

@pawelfus

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2015

I don't see any issue with that anymore (tested with latest, merged master and bug fix branches).

However I found new bug: #4670

@pawelfus

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2015

Edit: found required commit: this one.

@TorsteinHonsi

This comment has been minimized.

Copy link
Collaborator

commented Oct 27, 2015

So which commits do I need to cherry-pick in order to keep safe?

@pawelfus

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2015

These two:

  • fix for the issue above: this
  • test for the issue above: this (sorry for missing tests in the above one)

Fix for merge master&bugfix: #3636 - but those are already on the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.