New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"no data to display" dosesn't hide after adding points to treemap #4631

Closed
christopher-szu opened this Issue Oct 7, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@christopher-szu

christopher-szu commented Oct 7, 2015

http://jsfiddle.net/vjpduav0/7/

the "no data to display" text does not hide after adding points to a initially empty treemap,

i've made the treemap transparent so it is easier to see the problem

in the original no-data-to-display demo with pie chart, the text does go away

http://jsfiddle.net/gh/get/jquery/1.7.2/highslide-software/highcharts.com/tree/master/samples/highcharts/no-data-to-display/no-data-pie/

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Oct 7, 2015

Collaborator

@jon-a-nygaard The no-data module gives each series type a hasData method. The tree map probably hasn't got the right one.

PS: Remember to add a unit test for regression.

Collaborator

TorsteinHonsi commented Oct 7, 2015

@jon-a-nygaard The no-data module gives each series type a hasData method. The tree map probably hasn't got the right one.

PS: Remember to add a unit test for regression.

@jon-a-nygaard

This comment has been minimized.

Show comment
Hide comment
@jon-a-nygaard

jon-a-nygaard Feb 24, 2016

Collaborator

This issue will be fixed in an upcoming maintenance release. For those in need of a workaround can try the suggested below.

Workaround:
Open no-data-to-display.src.js and replace the following code which is located around line 55.

// Replace this code
each(['pie', 'gauge', 'waterfall', 'bubble'], function (type) {
    if (seriesTypes[type]) {
        seriesTypes[type].prototype.hasData = hasDataPie;
    }
});

// With this code
each(['pie', 'gauge', 'waterfall', 'bubble', 'treemap'], function (type) {
    if (seriesTypes[type]) {
        seriesTypes[type].prototype.hasData = hasDataPie;
    }
});

Also remember to load the no-data-to-display.src.js after treemap.src.js

Collaborator

jon-a-nygaard commented Feb 24, 2016

This issue will be fixed in an upcoming maintenance release. For those in need of a workaround can try the suggested below.

Workaround:
Open no-data-to-display.src.js and replace the following code which is located around line 55.

// Replace this code
each(['pie', 'gauge', 'waterfall', 'bubble'], function (type) {
    if (seriesTypes[type]) {
        seriesTypes[type].prototype.hasData = hasDataPie;
    }
});

// With this code
each(['pie', 'gauge', 'waterfall', 'bubble', 'treemap'], function (type) {
    if (seriesTypes[type]) {
        seriesTypes[type].prototype.hasData = hasDataPie;
    }
});

Also remember to load the no-data-to-display.src.js after treemap.src.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment