New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow buttons without tooltips in exporting module #4647

Closed
jhegeman opened this Issue Oct 10, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@jhegeman

jhegeman commented Oct 10, 2015

Dear Highcharters,

First of all a big thank you for this sweet tool! The 'issue' I have is a very minor one, really. If one defines a custom button using the exporting module (see this fiddle: http://jsfiddle.net/jcyu7amm/1/), the tooltip will show 'undefined'. I know one can tweak this adding to the lang settings, but in this case I would prefer not having any tooltip at all. Would it be possible to just check for 'undefined' and in that case show no tooltip, please?

Best regards,
Jeroen

@pawelfus

This comment has been minimized.

Contributor

pawelfus commented Oct 12, 2015

Internal note:
Probably adding checking here would be enough, like this:

            title: pick(chart.options.lang[btnOptions._titleKey], ''),

Sample: http://jsfiddle.net/jcyu7amm/2/

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Oct 12, 2015

@pawelfus Yes, that's fine!

@pawelfus

This comment has been minimized.

Contributor

pawelfus commented Oct 15, 2015

I see a lot of changes with date for the product - something changed in ant build file?

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Oct 19, 2015

Yes, the gulp file adds the current date. See this line. My though was that it would help users to see exactly when the file in development was built, but on the down side it creates a lot of garbage in the commits, so I'm not sure if it's a good idea. At least it should only apply to the files actually changed in the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment