New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zones - markers' fill for positive values #4670

Closed
pawelfus opened this Issue Oct 19, 2015 · 10 comments

Comments

Projects
None yet
5 participants
@pawelfus
Contributor

pawelfus commented Oct 19, 2015

Demo: http://jsfiddle.net/pq47vrbh/

Only orange (negative - I guess) markers have proper fill.

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Oct 19, 2015

Contributor

Connected to #3636.

Internal note:
The main question is what should have higher priority on hover? Zone-color or point.states.hover.color?
We need to consider standard series and column-based series ( http://jsfiddle.net/pq47vrbh/2/ - columns by default brightens color inherited from series, while other series don't do that )

Contributor

pawelfus commented Oct 19, 2015

Connected to #3636.

Internal note:
The main question is what should have higher priority on hover? Zone-color or point.states.hover.color?
We need to consider standard series and column-based series ( http://jsfiddle.net/pq47vrbh/2/ - columns by default brightens color inherited from series, while other series don't do that )

@pawelfus pawelfus self-assigned this Oct 19, 2015

@maschwenk

This comment has been minimized.

Show comment
Hide comment
@maschwenk

maschwenk Nov 2, 2015

It seems to me that zone-color is more intuitive but maybe only overridden when point.states.hover.color is actually user defined. Is that possible?

maschwenk commented Nov 2, 2015

It seems to me that zone-color is more intuitive but maybe only overridden when point.states.hover.color is actually user defined. Is that possible?

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Nov 6, 2015

Collaborator

I agree with @maschwenk . point.states.hover.color is not defined by default.

Collaborator

TorsteinHonsi commented Nov 6, 2015

I agree with @maschwenk . point.states.hover.color is not defined by default.

@goodforenergy

This comment has been minimized.

Show comment
Hide comment
@goodforenergy

goodforenergy Apr 14, 2016

Would love this fix, will it make it into the next release?

goodforenergy commented Apr 14, 2016

Would love this fix, will it make it into the next release?

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Apr 15, 2016

Collaborator

It will now, thanks for writing!

Collaborator

TorsteinHonsi commented Apr 15, 2016

It will now, thanks for writing!

@goodforenergy

This comment has been minimized.

Show comment
Hide comment
@goodforenergy

goodforenergy commented Apr 19, 2016

Thanks! :)

@goodforenergy

This comment has been minimized.

Show comment
Hide comment
@goodforenergy

goodforenergy May 8, 2016

Hi all. Is it expected that column type charts still get series fill on hover, even when zones are specified (as seen here)? I was hoping they'd behave like their line marker counterparts.

If not, is there a way to override the default behaviour to achieve this?

goodforenergy commented May 8, 2016

Hi all. Is it expected that column type charts still get series fill on hover, even when zones are specified (as seen here)? I was hoping they'd behave like their line marker counterparts.

If not, is there a way to override the default behaviour to achieve this?

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus May 9, 2016

Contributor

It's issue with brightness which sets a color for a point (even when udefined - color is inherited from series). For workaround, set colorByPoint: true, demo: http://jsfiddle.net/29a0hmx3/1/

Contributor

pawelfus commented May 9, 2016

It's issue with brightness which sets a color for a point (even when udefined - color is inherited from series). For workaround, set colorByPoint: true, demo: http://jsfiddle.net/29a0hmx3/1/

@goodforenergy

This comment has been minimized.

Show comment
Hide comment
@goodforenergy

goodforenergy May 9, 2016

@pawelfus wonderful, thanks! Is that an issue you'd like me to raise, or expected behaviour?

goodforenergy commented May 9, 2016

@pawelfus wonderful, thanks! Is that an issue you'd like me to raise, or expected behaviour?

@obar

This comment has been minimized.

Show comment
Hide comment
@obar

obar Jun 20, 2016

It looks like I'm still seeing this issue when points are dense enough for markers to be hidden because of overlap (large radius, wide display). hover state shows red markers for both of these points in this modified demo: http://jsfiddle.net/ncchm8v1/

Should this issue be reopened or is this a different one?

obar commented Jun 20, 2016

It looks like I'm still seeing this issue when points are dense enough for markers to be hidden because of overlap (large radius, wide display). hover state shows red markers for both of these points in this modified demo: http://jsfiddle.net/ncchm8v1/

Should this issue be reopened or is this a different one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment