New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing plotband when range is small #4964

Closed
sebastianbochan opened this Issue Jan 27, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@sebastianbochan
Contributor

sebastianbochan commented Jan 27, 2016

In case when we have i.e two plotbands, one of them is missing.

Example: http://jsfiddle.net/a30rcj24/

Internal note
We can observe two different behaviours in HS / HC

  1. In HC - there are two paths, but one of them has the same x values, so is "hidden".
  2. In HS - there is single path, but second is not printed

Maybe in that scenario we consider to print that plotband as 1px, instead of round to the same x / skip path?

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Jan 28, 2016

Collaborator

Maybe in that scenario we consider to print that plotband as 1px, instead of round to the same x / skip path?

Yes, I think we need to do that, since it doesn't have a stroke.

Collaborator

TorsteinHonsi commented Jan 28, 2016

Maybe in that scenario we consider to print that plotband as 1px, instead of round to the same x / skip path?

Yes, I think we need to do that, since it doesn't have a stroke.

@bryan-ash

This comment has been minimized.

Show comment
Hide comment
@bryan-ash

bryan-ash Mar 24, 2017

I can confirm that 89d37b7 fixes this issue.

Unfortunately the label for the plotBand is not rendered because path.flat = path.toString() === toPath.toString() is evaluated before the adjustment.

See updated jsfiddle with labels

bryan-ash commented Mar 24, 2017

I can confirm that 89d37b7 fixes this issue.

Unfortunately the label for the plotBand is not rendered because path.flat = path.toString() === toPath.toString() is evaluated before the adjustment.

See updated jsfiddle with labels

@bryan-ash

This comment has been minimized.

Show comment
Hide comment
@bryan-ash

bryan-ash Mar 24, 2017

@TorsteinHonsi I just realized this issue, and suggested patch, are from last February, not this year!

Are there any plans to move forward on this?

bryan-ash commented Mar 24, 2017

@TorsteinHonsi I just realized this issue, and suggested patch, are from last February, not this year!

Are there any plans to move forward on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment