Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When axis labels are aligned left, space reserveSpace option is no longer respected. #5286

Closed
eggers opened this issue May 4, 2016 · 6 comments
Closed

Comments

@eggers
Copy link

@eggers eggers commented May 4, 2016

Expected behaviour

Labels should take the same space whether align: "left" or align: "center" is used

Actual behaviour

When labels are aligned left (xAxis labels on a bar chart), space is no longer reserved for the labels.

Live demo of the issue

http://jsfiddle.net/w315zkaf/

Steps to reproduce the behaviour

Modify the sample bar chart, just addinging: labels: {align: 'left'} to the xAxis options.

Affected browser(s)

@eggers
Copy link
Author

@eggers eggers commented May 4, 2016

My jsfiddle sample wasn't added: http://jsfiddle.net/w315zkaf/

@SpacePrez
Copy link

@SpacePrez SpacePrez commented Oct 7, 2016

I'm also experiencing this same issue. HighCharts StackBar has serious bugs with labels due to the x-axis being on the left side.

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Oct 19, 2016

The rationale is that Highcharts assumes you want to put the labels inside, like this: http://jsfiddle.net/highcharts/w315zkaf/2/ .

That looks good on a value axis, not so good on a category axis with a stacked bar.

We need to modify the reserveSpace option. Currently it can be set to false to ignore the space of the label, but it should also be possible to set it to true to force the axis to reserve space, regardless of alignment. Then the default value should be null, which will be the current behaviour, a best guess based on alignment.

Related source code.

@Izothep
Copy link
Contributor

@Izothep Izothep commented Oct 18, 2017

+1

TorsteinHonsi added a commit that referenced this issue Dec 14, 2017
…tting it to false, could not be set to true to force reserved space. See #5286.
@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Dec 14, 2017

It's fixed now, but allowing the reserveSpace option to be set to true explicitly. See the fix applied at http://jsfiddle.net/highcharts/w315zkaf/5/.

This will be part of v6.0.4, shipping within a few days.

@stale
Copy link

@stale stale bot commented Sep 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the Status: Stale label Sep 24, 2019
@stale stale bot closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants