Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwated animation of series when they get updated #5294

Closed
KacperMadej opened this issue May 6, 2016 · 7 comments
Closed

Unwated animation of series when they get updated #5294

KacperMadej opened this issue May 6, 2016 · 7 comments

Comments

@KacperMadej
Copy link
Contributor

@KacperMadej KacperMadej commented May 6, 2016

Expected behaviour

Points should be shifted without changing their values multiple times.

Actual behaviour

Series is getting squeezed after new point is added and back to normal shape.

Live demo of the issue

http://jsfiddle.net/sxkrtgL1/

Looks like the problems is caused by dataGrouping, because there is no issue if dataGrouping is disabled - http://jsfiddle.net/sxkrtgL1/1/

@CrazyFunker
Copy link

@CrazyFunker CrazyFunker commented May 6, 2016

Please notice that the navigation bar is experiencing the same problem, regardless of the dataGrouping enabled or not.

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented May 11, 2016

@KacperMadej
Copy link
Contributor Author

@KacperMadej KacperMadej commented May 25, 2016

+1

@KacperMadej
Copy link
Contributor Author

@KacperMadej KacperMadej commented May 25, 2016

Another demo (however, this might not be the same issue):
http://www.highcharts.com/stock/demo/dynamic-update

Steps:

  1. move navigator's selection to middle of x axis to see the line twist in place
@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented May 26, 2016

Thanks Kacper, it's the same issue. The problem is that shift is set to 1 when adding a point, but the logic doesn't take data grouping or shifting extremes into account. We need a new functionality that is aware of the actual x values of the graph.

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Jun 9, 2016

Workaround

This issue was introduced with Highstock 4.2.5. Before that we didn't even support animation on addPoint in Highstock. To go back to how it was, just set the animation parameter to false: http://jsfiddle.net/highcharts/sxkrtgL1/4/.

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Jun 15, 2016

Note to self:
The commit above also introduces support for animating the graph sideways not only when running addPoint, but also when zooming. It can be seen in the basic Highstock sample by dragging the scrollbar to the middle, then click the right scrollbar button. What is missing now is support for animating in other direction, when clicking the left scrollbar button. It must be implemented in the initPath function.


Edit 2016-06-16:
Sideways animation on left scrollbar button is now implemented: http://jsfiddle.net/pvL8sr8a/1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants