New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polar chart and arearange series not working #5528

Closed
killzoner opened this Issue Jul 25, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@killzoner

killzoner commented Jul 25, 2016

Hi,

I was trying to make polar chart and arearange series working together. I couldn't get anything good until i found this issue : #3419, marked as solved.

The example seems not to be working anymore : http://jsfiddle.net/highcharts/30q95we5/1/

capture

Playing with versions, i saw that it's broken since v4.2.2 (here is the working version in v4.2.1 : http://jsfiddle.net/fchj8yr6/)

capture2

Thanks for the great work

@jon-a-nygaard jon-a-nygaard added the Bug label Jul 29, 2016

@ManYang

This comment has been minimized.

Show comment
Hide comment
@ManYang

ManYang Aug 2, 2016

I take a look at the code a little with comparison of fixed version. The is something I found may help for the fix.
First, for the seriesTypes.arearange class, in the getGraphPath function, there is pointShim obj, if we comment out highAreaPoints.push(pointShim); and highPoints.push(pointShim); the mess is disappear and draw the inner layer of the graph, looks like:
screen shot 2016-08-02 at 1 01 58 pm

Second,the linePath = [].concat(lowerPath, higherPath) looks like just get the bottom line, higherPath come from highPoints but in the class there is no function assign value to highpoint, looks the highpoint come from somewhere else.

ManYang commented Aug 2, 2016

I take a look at the code a little with comparison of fixed version. The is something I found may help for the fix.
First, for the seriesTypes.arearange class, in the getGraphPath function, there is pointShim obj, if we comment out highAreaPoints.push(pointShim); and highPoints.push(pointShim); the mess is disappear and draw the inner layer of the graph, looks like:
screen shot 2016-08-02 at 1 01 58 pm

Second,the linePath = [].concat(lowerPath, higherPath) looks like just get the bottom line, higherPath come from highPoints but in the class there is no function assign value to highpoint, looks the highpoint come from somewhere else.

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Aug 3, 2016

Collaborator

Thanks for your inputs!

Collaborator

TorsteinHonsi commented Aug 3, 2016

Thanks for your inputs!

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Aug 4, 2016

Collaborator

Related: #3419.

It broke with the great null-stack refactoring.

Collaborator

TorsteinHonsi commented Aug 4, 2016

Related: #3419.

It broke with the great null-stack refactoring.

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Aug 4, 2016

Collaborator

Demo with the fix applied: http://jsfiddle.net/highcharts/30q95we5/3/

Collaborator

TorsteinHonsi commented Aug 4, 2016

Demo with the fix applied: http://jsfiddle.net/highcharts/30q95we5/3/

@killzoner

This comment has been minimized.

Show comment
Hide comment
@killzoner

killzoner Aug 4, 2016

Well done, thanks!

killzoner commented Aug 4, 2016

Well done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment