New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bubble charts selectively hide data points if the chart is small #5873

Closed
dbasner opened this Issue Oct 24, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@dbasner

dbasner commented Oct 24, 2016

Expected behaviour

Draws bubbles for every single data point I pass it, regardless of the width/height of the containing box. Should do the same for any data point in any type of graph.

Actual behaviour

Hides some data points if the height of the chart is short, and when it does hide this data it does not notify the user.

Affected browser(s)

Google Chrome 53.0.2785.101

scatterchartsmalldatahidden
scatterchartlargedatashown

@oysteinmoseng

This comment has been minimized.

Show comment
Hide comment
@oysteinmoseng

oysteinmoseng Oct 25, 2016

Collaborator

Thanks for reporting. Do you have a live demo of the issue? Our bubble chart demo seems to handle low heights without hiding: http://jsfiddle.net/oysteinmoseng/5rqoz5hr/.

Collaborator

oysteinmoseng commented Oct 25, 2016

Thanks for reporting. Do you have a live demo of the issue? Our bubble chart demo seems to handle low heights without hiding: http://jsfiddle.net/oysteinmoseng/5rqoz5hr/.

@dbasner

This comment has been minimized.

Show comment
Hide comment
@dbasner

dbasner Oct 25, 2016

Here is a jsfiddle: http://jsfiddle.net/dbasner/8457ctpj/11/, change the height of the div between something like 200px and 500px and notice how it does not show all the data. Let me know if this helps or if you have any questions, thanks for the response!

dbasner commented Oct 25, 2016

Here is a jsfiddle: http://jsfiddle.net/dbasner/8457ctpj/11/, change the height of the div between something like 200px and 500px and notice how it does not show all the data. Let me know if this helps or if you have any questions, thanks for the response!

@oysteinmoseng

This comment has been minimized.

Show comment
Hide comment
@oysteinmoseng

oysteinmoseng Oct 26, 2016

Collaborator

This seems to be an issue between bubble.minSize and maxSize. Because maxSize is defined in percentage, you risk it becoming smaller than minSize when you resize the chart. We should probably add some logic to catch these edge cases.

Collaborator

oysteinmoseng commented Oct 26, 2016

This seems to be an issue between bubble.minSize and maxSize. Because maxSize is defined in percentage, you risk it becoming smaller than minSize when you resize the chart. We should probably add some logic to catch these edge cases.

@dbasner

This comment has been minimized.

Show comment
Hide comment
@dbasner

dbasner Oct 26, 2016

That's a good point, I'll switch it to be consistent on my end. Thank you for your help Øystein!

dbasner commented Oct 26, 2016

That's a good point, I'll switch it to be consistent on my end. Thank you for your help Øystein!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment