Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An inverted waterfall chart is not drawn correctly #5911

Closed
morganfree opened this issue Oct 31, 2016 · 7 comments
Closed

An inverted waterfall chart is not drawn correctly #5911

morganfree opened this issue Oct 31, 2016 · 7 comments

Comments

@morganfree
Copy link
Contributor

@morganfree morganfree commented Oct 31, 2016

Expected behaviour

A waterfall chart is drawn correctly in an inverted chart with reversed axis.
chart.inverted: false, xAxis.reversed: false, yAxis.reversed: false ok http://jsfiddle.net/t2Lha3at/7/
chart.inverted: false, xAxis.reversed: true, yAxis.reversed: false ok http://jsfiddle.net/t2Lha3at/8/

Actual behaviour

It seems that when a chart is inverted it caused misplacing of points or connectors depending on axis reversion.

chart.inverted: false, xAxis.reversed: false, yAxis.reversed: true points ok, connectors misplaced http://jsfiddle.net/t2Lha3at/9/
chart.inverted: false, xAxis.reversed: true, yAxis.reversed: true points ok, connectors misplaced http://jsfiddle.net/t2Lha3at/10/
chart.inverted: true, xAxis.reversed: false, yAxis.reversed: false points misplaced, connectors ok http://jsfiddle.net/t2Lha3at/11/
chart.inverted: true, xAxis.reversed: true, yAxis.reversed: false points misplaced, connectors ok http://jsfiddle.net/t2Lha3at/12/
chart.inverted: true, xAxis.reversed: false, yAxis.reversed: true points misplaced, connectors misplaced http://jsfiddle.net/t2Lha3at/13/
chart.inverted: true, xAxis.reversed: true, yAxis.reversed: true points misplaced, connectors misplaced http://jsfiddle.net/t2Lha3at/14/

@oysteinmoseng
Copy link
Member

@oysteinmoseng oysteinmoseng commented Nov 1, 2016

Thank you for reporting this.

@sebastianbochan
Copy link
Contributor

@sebastianbochan sebastianbochan commented Mar 23, 2017

+1

Internal note
worked fine in 4.2.6

@jacowley
Copy link

@jacowley jacowley commented Apr 6, 2017

@sebastianbochan I think it worked fine in 4.2.6, but is broken in 4.2.7.

@sebastianbochan
Copy link
Contributor

@sebastianbochan sebastianbochan commented Apr 6, 2017

@jacowley You are absolutey right, my bad. I edited my last comment.

@pawelfus pawelfus self-assigned this Apr 6, 2017
@jacowley
Copy link

@jacowley jacowley commented Apr 6, 2017

@pawelfus I believe it was caused by the fix for #5646 406257d

@pawelfus
Copy link
Contributor

@pawelfus pawelfus commented Apr 6, 2017

Hi @jacowley - I agree, this commit is the culprit. Reverting this commit fixes issue with bars positions, but issue with reversed yAxis and connectors remains.

@pawelfus
Copy link
Contributor

@pawelfus pawelfus commented Apr 7, 2017

Demo with fix applied: http://jsfiddle.net/9bqardyp/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants