New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cell border of heatmap is not a rectangle #6064

Closed
hotohoto opened this Issue Dec 1, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@hotohoto

hotohoto commented Dec 1, 2016

Expected behaviour

The cell border is supposed to be a rectangle.

Actual behaviour

Only bottom and top sides of the border are visible.

Live demo with steps to reproduce

http://jsfiddle.net/hotohoto/4uwu6nm1/1/

Affected browser(s)

I've tested it with Chrome.

@jon-a-nygaard

This comment has been minimized.

Show comment
Hide comment
@jon-a-nygaard

jon-a-nygaard Dec 1, 2016

Collaborator

Internal Note: Treemap had the same dilemma, which was solved by setting a higher zIndex when state is hover in Point.setState
Edit: The note above only applies to borders regarding hover

Collaborator

jon-a-nygaard commented Dec 1, 2016

Internal Note: Treemap had the same dilemma, which was solved by setting a higher zIndex when state is hover in Point.setState
Edit: The note above only applies to borders regarding hover

@jon-a-nygaard

This comment has been minimized.

Show comment
Hide comment
@jon-a-nygaard

jon-a-nygaard Dec 1, 2016

Collaborator

Hi @hotohoto Here's a workaround that you can try out, let me know if this is an acceptable solution for you.

Collaborator

jon-a-nygaard commented Dec 1, 2016

Hi @hotohoto Here's a workaround that you can try out, let me know if this is an acceptable solution for you.

@jon-a-nygaard jon-a-nygaard self-assigned this Dec 1, 2016

@hotohoto

This comment has been minimized.

Show comment
Hide comment
@hotohoto

hotohoto Dec 2, 2016

@jon-a-nygaard, that is a great solution!
Thanks

hotohoto commented Dec 2, 2016

@jon-a-nygaard, that is a great solution!
Thanks

@jon-a-nygaard

This comment has been minimized.

Show comment
Hide comment
@jon-a-nygaard

jon-a-nygaard Dec 2, 2016

Collaborator

You're welcome!

I added a change which will fix the issue with border color on points in hover state. But I will close this issue as a won't fix, because we do not see a proper way to accomodate borders on points in a normal state.
For instance, shrinking the size of the points to make room for the border size is an option we consider to be invalid, because the points would get incorrect dimensions.

Should anyone have further information on this issue, feel free to comment.

Collaborator

jon-a-nygaard commented Dec 2, 2016

You're welcome!

I added a change which will fix the issue with border color on points in hover state. But I will close this issue as a won't fix, because we do not see a proper way to accomodate borders on points in a normal state.
For instance, shrinking the size of the points to make room for the border size is an option we consider to be invalid, because the points would get incorrect dimensions.

Should anyone have further information on this issue, feel free to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment