New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled mode: bubble halo stays for ever per series #6067

Closed
KacperMadej opened this Issue Dec 1, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@KacperMadej
Contributor

KacperMadej commented Dec 1, 2016

Expected behaviour

Halo removed after state of a point changes.

Actual behaviour

Halo stays and hovering all points makes halos for all points.

Live demo with steps to reproduce

http://jsfiddle.net/7Lw1esye/

  1. Hover over all points - halos are staying
  2. Zoom to any 3 points
  3. Halo is not updated after zoom
@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Dec 1, 2016

Contributor

It's a general issue, not related to styled mode. Demo: http://jsfiddle.net/7Lw1esye/3/

Contributor

pawelfus commented Dec 1, 2016

It's a general issue, not related to styled mode. Demo: http://jsfiddle.net/7Lw1esye/3/

@pawelfus pawelfus added the Bug label Dec 1, 2016

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Dec 1, 2016

Contributor

Internal note:
Bubble series resizes the halo to the original bubble size, not to the size == 0. That causes the halo to remain after resize (actually, every halo stays there, but the ones size == 0 are not visible).

I think we have two (at least) possible solutions to fix this:

  • after the animation, really hide the halo, e.g.:

      	halo.animate({
      		d: point.haloPath(0)
      	}, {
      		complete: function ()  {
      			halo.attr({
      				d: ''
                                    // OR: visibility: 'hidden' and restore this above
      			});
      		}
      	}); // Hide
    
  • move halo logic to the separate method, so bubble series can overwrite this. That may not be as bad as it seems, perhaps it will be easier to fix some other issues, for example #5746, #4198 and #3533 (so we can call this method in other places, to update the halo).

Contributor

pawelfus commented Dec 1, 2016

Internal note:
Bubble series resizes the halo to the original bubble size, not to the size == 0. That causes the halo to remain after resize (actually, every halo stays there, but the ones size == 0 are not visible).

I think we have two (at least) possible solutions to fix this:

  • after the animation, really hide the halo, e.g.:

      	halo.animate({
      		d: point.haloPath(0)
      	}, {
      		complete: function ()  {
      			halo.attr({
      				d: ''
                                    // OR: visibility: 'hidden' and restore this above
      			});
      		}
      	}); // Hide
    
  • move halo logic to the separate method, so bubble series can overwrite this. That may not be as bad as it seems, perhaps it will be easier to fix some other issues, for example #5746, #4198 and #3533 (so we can call this method in other places, to update the halo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment