Bad rendering when series data is an empty object #6080

Open
lucasmauro opened this Issue Dec 2, 2016 · 5 comments

Projects

None yet

4 participants

@lucasmauro
lucasmauro commented Dec 2, 2016 edited

Expected behaviour

When series.data contains an empty object as a value, this value is not rendered.

Actual behaviour

When series.data contains an empty object as a value, a 0 floats around the chart.

Live demo with steps to reproduce

http://jsfiddle.net/k0botpL0/1/

Affected browser(s)

@oysteinmoseng
Collaborator

Thank you for reporting. Workaround: Use null points - example.

Issue since 4.2.7.

@TorsteinHonsi
Collaborator
TorsteinHonsi commented Dec 5, 2016 edited

Fails since 7903240 - the point now has shapeArgs even when it's null.

@sebastianbochan sebastianbochan self-assigned this Dec 5, 2016
@sebastianbochan
Collaborator
sebastianbochan commented Dec 5, 2016 edited

@TorsteinHonsi the commit looks like promising, but unfortunately it breaks the treemap labels. #4812.

@TorsteinHonsi TorsteinHonsi added a commit that referenced this issue Dec 5, 2016
@TorsteinHonsi TorsteinHonsi Reverted #6080. 44e26d3
@TorsteinHonsi
Collaborator

You're right. Reopening this. I think instead we need to go back to the fix for #3169 and move that logic to the drilldown module, since it's the only place where we expect a null column to have a shape. It also shaves off some bloat from the core.

@TorsteinHonsi TorsteinHonsi reopened this Dec 5, 2016
@sebastianbochan
Collaborator
sebastianbochan commented Dec 5, 2016 edited

Internal note
I think that one of possibly solutions is checking point.plotY and then set a null for the y param (point init function). It seems not be perfect, but pass all tests as I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment