New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad rendering when series data is an empty object #6080

Open
lucasmauro opened this Issue Dec 2, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@lucasmauro

lucasmauro commented Dec 2, 2016

Expected behaviour

When series.data contains an empty object as a value, this value is not rendered.

Actual behaviour

When series.data contains an empty object as a value, a 0 floats around the chart.

Live demo with steps to reproduce

http://jsfiddle.net/k0botpL0/1/

Affected browser(s)

@oysteinmoseng

This comment has been minimized.

Show comment
Hide comment
@oysteinmoseng

oysteinmoseng Dec 3, 2016

Collaborator

Thank you for reporting. Workaround: Use null points - example.

Issue since 4.2.7.

Collaborator

oysteinmoseng commented Dec 3, 2016

Thank you for reporting. Workaround: Use null points - example.

Issue since 4.2.7.

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Dec 5, 2016

Collaborator

Fails since 7903240 - the point now has shapeArgs even when it's null.

Collaborator

TorsteinHonsi commented Dec 5, 2016

Fails since 7903240 - the point now has shapeArgs even when it's null.

@sebastianbochan sebastianbochan self-assigned this Dec 5, 2016

@sebastianbochan

This comment has been minimized.

Show comment
Hide comment
@sebastianbochan

sebastianbochan Dec 5, 2016

Contributor

@TorsteinHonsi the commit looks like promising, but unfortunately it breaks the treemap labels. #4812.

Contributor

sebastianbochan commented Dec 5, 2016

@TorsteinHonsi the commit looks like promising, but unfortunately it breaks the treemap labels. #4812.

TorsteinHonsi added a commit that referenced this issue Dec 5, 2016

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Dec 5, 2016

Collaborator

You're right. Reopening this. I think instead we need to go back to the fix for #3169 and move that logic to the drilldown module, since it's the only place where we expect a null column to have a shape. It also shaves off some bloat from the core.

Collaborator

TorsteinHonsi commented Dec 5, 2016

You're right. Reopening this. I think instead we need to go back to the fix for #3169 and move that logic to the drilldown module, since it's the only place where we expect a null column to have a shape. It also shaves off some bloat from the core.

@TorsteinHonsi TorsteinHonsi reopened this Dec 5, 2016

@sebastianbochan

This comment has been minimized.

Show comment
Hide comment
@sebastianbochan

sebastianbochan Dec 5, 2016

Contributor

Internal note
I think that one of possibly solutions is checking point.plotY and then set a null for the y param (point init function). It seems not be perfect, but pass all tests as I see.

Contributor

sebastianbochan commented Dec 5, 2016

Internal note
I think that one of possibly solutions is checking point.plotY and then set a null for the y param (point init function). It seems not be perfect, but pass all tests as I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment