Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor observations : highcharts-negative extry twice. #6114

Closed
garybrain opened this issue Dec 8, 2016 · 4 comments
Closed

Minor observations : highcharts-negative extry twice. #6114

garybrain opened this issue Dec 8, 2016 · 4 comments
Assignees

Comments

@garybrain
Copy link

@garybrain garybrain commented Dec 8, 2016

Expected behaviour

Single class entry for .highcharts-negative

Actual behaviour

double entry for .highcharts-negative

Live demo with steps to reproduce

http://jsfiddle.net/gh/get/jquery/1.7.2/highcharts/highcharts/tree/master/samples/highcharts/css/series-negative-color/

Also testing with the Master Branch,

If you inspect one of the points we can see the double entry.

<path d="M 227 199.36 L 231 203.36 227 207.36 223 203.36 Z" class="highcharts-point highcharts-negative highcharts-color-1 highcharts-negative "></path>
Also noticed in the CSS File.

https://code.highcharts.com/css/highcharts.css

Duplicate CSS Entries, the 2nd "inherit" I disabled as it was not applying the stroke colour I was trying to configure.

.highcharts-column-series .highcharts-point {
stroke: #ffffff;
transition: fill-opacity 250ms;
}

and

.highcharts-column-series .highcharts-point {
stroke: inherit;
/* use point color */
}

Affected browser(s)

@pawelfus
Copy link
Contributor

@pawelfus pawelfus commented Dec 8, 2016

Thanks for reporting!

Internal note:
Issue comes from getClassName in point. Most probably zone applies negative class and point.negative too.

@pawelfus pawelfus added the Type: Bug label Dec 8, 2016
@oysteinmoseng
Copy link
Member

@oysteinmoseng oysteinmoseng commented Dec 12, 2016

Yes, zones are used for negative color, and then have a className of highcharts-negative. See https://github.com/highcharts/highcharts/blob/master/js/parts/Series.js#L433

@oysteinmoseng
Copy link
Member

@oysteinmoseng oysteinmoseng commented Dec 14, 2016

Assigning the remaining CSS part of the issue to you @TorsteinHonsi

@stale
Copy link

@stale stale bot commented Sep 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the Status: Stale label Sep 24, 2019
@stale stale bot closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants