New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline exporting module: on Edge has wrong background color #6157

Closed
KacperMadej opened this Issue Dec 16, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@KacperMadej
Contributor

KacperMadej commented Dec 16, 2016

Behaviour

Exported to JPEG or PNG chart is almost all black and size is wrong - right part is clipped out of the image by like 30%.

On master branch version of the module exporting is not working at all.

Live demo with steps to reproduce

Export to JPEG or PNG and view the exported image:
http://jsfiddle.net/vepx7mqs/1/

On master:
http://jsfiddle.net/vepx7mqs/

Affected browser(s)

Edge

@oysteinmoseng oysteinmoseng added the Bug label Dec 16, 2016

@oysteinmoseng

This comment has been minimized.

Show comment
Hide comment
@oysteinmoseng

oysteinmoseng Dec 16, 2016

Collaborator

Fails since 4.2.6. Before that, Edge PNG fell back to export server. So somehow this has never worked, but seems strange that it hasn't been picked up before. Will investigate further.

Collaborator

oysteinmoseng commented Dec 16, 2016

Fails since 4.2.6. Before that, Edge PNG fell back to export server. So somehow this has never worked, but seems strange that it hasn't been picked up before. Will investigate further.

@oysteinmoseng

This comment has been minimized.

Show comment
Hide comment
@oysteinmoseng

oysteinmoseng Dec 16, 2016

Collaborator

Related to #5410, which probably never got a proper conclusion for Edge with no embedded images.

Collaborator

oysteinmoseng commented Dec 16, 2016

Related to #5410, which probably never got a proper conclusion for Edge with no embedded images.

@oysteinmoseng

This comment has been minimized.

Show comment
Hide comment
@oysteinmoseng

oysteinmoseng Dec 16, 2016

Collaborator

Also found that Edge has a bug where it capitalizes several SVG attribute names (fill="red" becomes FILL="red"), which appears to mess up things across the board. I got downloading to work by using CanVG, but because of this bug the rendering is all wrong.

Looks like Edge and CanVG are not cooperating well, so browser detection and graceful fall back might be the only option. Before the fixes to #5410 Edge always failed and fell back anyway.

Collaborator

oysteinmoseng commented Dec 16, 2016

Also found that Edge has a bug where it capitalizes several SVG attribute names (fill="red" becomes FILL="red"), which appears to mess up things across the board. I got downloading to work by using CanVG, but because of this bug the rendering is all wrong.

Looks like Edge and CanVG are not cooperating well, so browser detection and graceful fall back might be the only option. Before the fixes to #5410 Edge always failed and fell back anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment