New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highstock: navigator jumps back on drag to right edge #6187

Open
KacperMadej opened this Issue Dec 29, 2016 · 4 comments

Comments

Projects
None yet
5 participants
@KacperMadej
Contributor

KacperMadej commented Dec 29, 2016

Expected behaviour

Navigator should move to the touched place.

Actual behaviour

It jumps back after a touch event ends.

Live demo with steps to reproduce

http://www.highcharts.com/stock/demo/candlestick-and-volume

  1. Open on iPhone
  2. Drag navigator (mask) to the center.
  3. Drag navigator (mask) to right side of the navigator.
  4. Navigator jumps back to the center position after the drag ends.

img_4303 1

Affected browser(s)

Mobile: iPhone 7

@KacperMadej

This comment has been minimized.

Show comment
Hide comment
@KacperMadej

KacperMadej Dec 29, 2016

Contributor

Another example:

ezgif com-58fc0optym

Contributor

KacperMadej commented Dec 29, 2016

Another example:

ezgif com-58fc0optym

@sebastianbochan

This comment has been minimized.

Show comment
Hide comment
@sebastianbochan

sebastianbochan Jan 13, 2017

Contributor

+1

Contributor

sebastianbochan commented Jan 13, 2017

+1

@eldjuve

This comment has been minimized.

Show comment
Hide comment
@eldjuve

eldjuve Mar 29, 2017

This fix simply disregards mouseevents, meaning the navigator will not respond to mouse interaction on a computer with a touch screen. Could it not be fixed by simply preventing default on touchevents instead? Ref: https://developer.mozilla.org/en-US/docs/Web/API/Touch_events/Supporting_both_TouchEvent_and_MouseEvent

eldjuve commented Mar 29, 2017

This fix simply disregards mouseevents, meaning the navigator will not respond to mouse interaction on a computer with a touch screen. Could it not be fixed by simply preventing default on touchevents instead? Ref: https://developer.mozilla.org/en-US/docs/Web/API/Touch_events/Supporting_both_TouchEvent_and_MouseEvent

TorsteinHonsi added a commit that referenced this issue Mar 31, 2017

Reverted fix for #6187, navigator jumped back after dragging on touch…
… devices.

The commit disabled mouse events on touch screens. Also suspected connection with #6457.

@TorsteinHonsi TorsteinHonsi reopened this Mar 31, 2017

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Mar 31, 2017

Collaborator

Reopened based on the comment above. Also I suspect that this caused #6457, that we haven't been able to reproduce, but comes with the same symptoms.

Collaborator

TorsteinHonsi commented Mar 31, 2017

Reopened based on the comment above. Also I suspect that this caused #6457, that we haven't been able to reproduce, but comes with the same symptoms.

@pawelfus pawelfus removed the Fix suggested label Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment