New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to dead clip paths after animation #6196

Closed
oysteinmoseng opened this Issue Jan 3, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@oysteinmoseng
Collaborator

oysteinmoseng commented Jan 3, 2017

As seen in http://jsfiddle.net/LLExL/6856/, the marker group holds a reference to a non-existing clip-path.

When removing the clip path after animation, we should also remove old references.

@oysteinmoseng oysteinmoseng added the Bug label Jan 3, 2017

@oysteinmoseng oysteinmoseng self-assigned this Jan 3, 2017

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Jan 4, 2017

Collaborator

The practical implication is that it fails rendering in Batik.

Collaborator

TorsteinHonsi commented Jan 4, 2017

The practical implication is that it fails rendering in Batik.

@oysteinmoseng

This comment has been minimized.

Show comment
Hide comment
@oysteinmoseng

oysteinmoseng Mar 21, 2017

Collaborator

It seems the applied fix doesn't work for multiple series: example. The one added by me present in hc5-fixes works, but there probably was a reason we didn't use that one. @TorsteinHonsi

Collaborator

oysteinmoseng commented Mar 21, 2017

It seems the applied fix doesn't work for multiple series: example. The one added by me present in hc5-fixes works, but there probably was a reason we didn't use that one. @TorsteinHonsi

@KacperMadej

This comment has been minimized.

Show comment
Hide comment
@KacperMadej

KacperMadej Mar 31, 2017

Contributor

@oysteinmoseng I am checking clip-paths and I am not able to find the problem in your last demo - is it resolved or I am checking something wrong?

Contributor

KacperMadej commented Mar 31, 2017

@oysteinmoseng I am checking clip-paths and I am not able to find the problem in your last demo - is it resolved or I am checking something wrong?

@oysteinmoseng

This comment has been minimized.

Show comment
Hide comment
@oysteinmoseng

oysteinmoseng Apr 3, 2017

Collaborator

@KacperMadej The problem seems to be fixed in 5.0.10. Closing again for now.

Collaborator

oysteinmoseng commented Apr 3, 2017

@KacperMadej The problem seems to be fixed in 5.0.10. Closing again for now.

TorsteinHonsi added a commit that referenced this issue Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment