New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone offset - missing ticks in DST #6278

Closed
sebastianbochan opened this Issue Jan 20, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@sebastianbochan
Contributor

sebastianbochan commented Jan 20, 2017

Expected behaviour

All ticks shoud be visible

Actual behaviour

The issue is when we have data which begins at non-equal hours. Ticks are missing.

Live demo with steps to reproduce

Demo:

Affected browser(s)

All

@TorsteinHonsi TorsteinHonsi added the Bug label Jan 23, 2017

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Jan 23, 2017

Collaborator

I was able to fix it by adding the timezone offset instead of adding it on this line.

minDate = new Date(min - getTZOffset(min)),
becomes:
minDate = new Date(min + getTZOffset(min)),

Which feels correct because it gives the correct minDate in this case. However, it breaks the test for unit-tests/axis/datetime-ticks, which I don't understand... Will continue to investigate.

Collaborator

TorsteinHonsi commented Jan 23, 2017

I was able to fix it by adding the timezone offset instead of adding it on this line.

minDate = new Date(min - getTZOffset(min)),
becomes:
minDate = new Date(min + getTZOffset(min)),

Which feels correct because it gives the correct minDate in this case. However, it breaks the test for unit-tests/axis/datetime-ticks, which I don't understand... Will continue to investigate.

@mcapewell

This comment has been minimized.

Show comment
Hide comment
@mcapewell

mcapewell Feb 16, 2017

Is there any update to this issue? We would like to fix this for our customers in an upcoming release of our software.

mcapewell commented Feb 16, 2017

Is there any update to this issue? We would like to fix this for our customers in an upcoming release of our software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment