Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosshair click extending "H.wrap" handler returns wrong index on stacked bar chart #6431

Closed
yashhy opened this issue Mar 5, 2017 · 6 comments
Closed
Assignees
Milestone

Comments

@yashhy
Copy link

@yashhy yashhy commented Mar 5, 2017

Expected behaviour

I'm trying to have a click handler on the crosshair and I followed this issue's comment to override this functionality and I kinda achieved it in this fiddle.

The fiddle works fine and returns me the index in clickOnCrosshair callback.

Actual behaviour

However if I change the chart type to stacked bar, index returned is always the first crosshair clicked, unless focused out from the chart and clicked back again where it returns the expected index first time. Regardless of what type the chart is, index of the clickOnCrosshair should always be the same.

Steps to reproduce

  1. Index works fine on override fiddle.
  2. Wrong index returned on stacked bar chart fiddle.
    • Click on a column observe the index in console, move to next column clicking will give the same index as before.
    • Click on a column observe the index in console, focus out from the chart and click back again the index is returned correctly.

Affected browser(s)

MacOS Sierra
Chrome : Version 56.0.2924.87 (64-bit)

Windows7
Chrome: Version 45.0.2454.99 m (64-bit)

@pawelfus
Copy link
Contributor

@pawelfus pawelfus commented Mar 6, 2017

Hi @yashhy

Thank you for reporting this issue! It should be resolved once one of our dev branches will be merged into the master: http://jsfiddle.net/8bedzxm5/3/ We should be able to release this as part of 5.0.8.

FYI @jon-a-nygaard

@yashhy
Copy link
Author

@yashhy yashhy commented Mar 6, 2017

@pawelfus thanks for your comment, may I know when is the realese 5.0.8 planned?

@pawelfus pawelfus added the Type: Bug label Mar 6, 2017
@pawelfus
Copy link
Contributor

@pawelfus pawelfus commented Mar 6, 2017

v5.0.8 should be released within a week or two.

@yashhy
Copy link
Author

@yashhy yashhy commented Mar 12, 2017

@pawelfus I see the new release v5.0.9, but did it broke the crosshair (color) hovering on bar chart? Initially when this bug was opened, I was able to hover the bar chart without moving out of the chart container, but now it seems to be broken.

The crosshair color hover happens only if we are within the bar chart area and move to the next bar, if you try to move your mouse around the chart without hovering the bar chart area, the crosshair color doesn't change at all. Here is the fiddle with version v5.0.9

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Mar 13, 2017

The last problem is probably the same as #6456.

@yashhy
Copy link
Author

@yashhy yashhy commented Mar 16, 2017

Based on this comment updating the fiddle for workaround.

jon-a-nygaard added a commit that referenced this issue Mar 23, 2017
@jon-a-nygaard jon-a-nygaard added this to the 5.0.10 milestone Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants