New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal "custom CSS properties" are not stripped from `style` #6474

Closed
hon2a opened this Issue Mar 15, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@hon2a

hon2a commented Mar 15, 2017

Expected behaviour

Internal "custom CSS properties" defined in SVGRenderer, such as textOutline, are by default not applied as DOM element style properties, i.e. they are stripped from style before it's applied to an element.

Actual behaviour

Properties like textOutline are applied as style properties along with the rest. As long as they're invalid CSS (for the given CSS parser implementation) they're ignored, so it's not an issue as of itself, but apart from showing up in dev tools, they pose a forward-compatibility risk (of actually becoming valid).

Live demo with steps to reproduce

Any demo using textOutline suffices, e.g. this one. Just inspect the text node of any data label.

Affected browser(s)

All

@hon2a hon2a changed the title from Internal "custom CSS properties" are applied to DOM nodes to Internal "custom CSS properties" are not stripped from `style` Mar 15, 2017

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Mar 16, 2017

Collaborator

Accidentally closed, sorry.

Collaborator

TorsteinHonsi commented Mar 16, 2017

Accidentally closed, sorry.

@TorsteinHonsi TorsteinHonsi reopened this Mar 16, 2017

@hon2a

This comment has been minimized.

Show comment
Hide comment
@hon2a

hon2a Mar 16, 2017

No problem. You do, however, have the wrong issue number on that commit.

hon2a commented Mar 16, 2017

No problem. You do, however, have the wrong issue number on that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment