New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataLabels issue with zero on a logarithmic axis #6585

Closed
laopunk opened this Issue Apr 10, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@laopunk

laopunk commented Apr 10, 2017

Expected behaviour

The data label should be snapped to the x axis, and centered withing its column space.

Actual behaviour

The data label is floating half way through the y axis height, and is not centered

Live demo with steps to reproduce

http://jsfiddle.net/0L0afe16/
Just run it and look at February's Tokyo

Affected browser(s)

Chrome on OSX

@pawelfus pawelfus self-assigned this Apr 10, 2017

@pawelfus pawelfus added the Bug label Apr 10, 2017

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Apr 10, 2017

Contributor

Thank you for reporting, I will take a look.

Contributor

pawelfus commented Apr 10, 2017

Thank you for reporting, I will take a look.

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Apr 18, 2017

Collaborator

@pawelfus It doesn't always make sense to draw it on the bottom of the Y axis... http://jsfiddle.net/highcharts/0L0afe16/3/

Maybe we should look for the threshold instead, or the part of the Y axis closest to the threshold || 0.

Collaborator

TorsteinHonsi commented Apr 18, 2017

@pawelfus It doesn't always make sense to draw it on the bottom of the Y axis... http://jsfiddle.net/highcharts/0L0afe16/3/

Maybe we should look for the threshold instead, or the part of the Y axis closest to the threshold || 0.

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Apr 18, 2017

Contributor

You are right, thanks! Threshold will be great (like here: http://jsfiddle.net/0L0afe16/5/ ), I will update the commit (using translatedThreshold).

Contributor

pawelfus commented Apr 18, 2017

You are right, thanks! Threshold will be great (like here: http://jsfiddle.net/0L0afe16/5/ ), I will update the commit (using translatedThreshold).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment