Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-axis label disappears with timezoneOffset #6636

Closed
Sydney-o9 opened this issue Apr 24, 2017 · 6 comments
Closed

X-axis label disappears with timezoneOffset #6636

Sydney-o9 opened this issue Apr 24, 2017 · 6 comments
Labels

Comments

@Sydney-o9
Copy link

@Sydney-o9 Sydney-o9 commented Apr 24, 2017

Expected behaviour

X-Axis datetime(s) should be labeled when timezone negative with multiple axis

Actual behaviour

X-Axis datetime(s) is not labeled when timezone negative with multiple axis.

Live demo with steps to reproduce

Demo which shows x-axis correctly labeled when timezoneOffset = 0
WORKING DEMO

Demo which shows x-axis NOT correctly labeled when timezoneOffset = -3 *60
NON WORKING DEMO

@Sydney-o9 Sydney-o9 changed the title Chart x-axis datetime not showing if Timezone negative X-axis label disappears with timezoneOffset Apr 24, 2017
@pawelfus
Copy link
Contributor

@pawelfus pawelfus commented Apr 24, 2017

Hi @Sydney-o9

Thank you for this report. Both demos are the same, but I assumed that the first one shouldn't have timezoneOffset. These are the results:

  • without timezone:
    screen shot 2017-04-24 at 17 54 06

  • with timezone:
    screen shot 2017-04-24 at 17 54 00

Tested with OSX + Chrome.

@Sydney-o9
Copy link
Author

@Sydney-o9 Sydney-o9 commented Apr 24, 2017

Hi @pawelfus,

My apologies, I have updated the jsfiddle, but still have the same issues, tested in:

  • Chrome 57.0.2987.133
  • Firefox 52.0.2
  • Safari 10.1

  • Without Timezone

Demo which shows x-axis correctly labeled: Working Demo

screen shot 2017-04-25 at 2 27 33 am


screen shot 2017-04-25 at 2 26 47 am

@Sydney-o9
Copy link
Author

@Sydney-o9 Sydney-o9 commented Apr 24, 2017

@pawelfus, just a quick heads up, it seems to be due to the width of the chart... which is why we both get different results. You can see what I mean if you change the window width in your fiddle.

However, without timezoneOffset, that issue does not exist and the chart width does not matter.

screen shot 2017-04-25 at 2 33 23 am

screen shot 2017-04-25 at 2 33 08 am

@pawelfus
Copy link
Contributor

@pawelfus pawelfus commented Apr 25, 2017

Thank you for the updates!

Demo with fixed width: http://jsfiddle.net/ezczk0mp/8/

@pawelfus pawelfus added the Type: Bug label Apr 25, 2017
@Sydney-o9
Copy link
Author

@Sydney-o9 Sydney-o9 commented Apr 25, 2017

Nice - thank you so much @pawelfus for looking into this.

@TorsteinHonsi
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi commented Apr 26, 2017

It's a regression in v5.0.8, fails since 1e0903c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.