New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost keeps redraw even with series.setVisible sets redraw to false #6648

Closed
onemenny opened this Issue Apr 26, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@onemenny

onemenny commented Apr 26, 2017

boost version 5.0.9

Actually Im having two problems:

  1. Calling series setVisible with second argument set to false, do fires immediate redraw. see code here totally ignores the second argument (boost module line 2600)
    wrap(Series.prototype, 'setVisible', function(proceed, vis) { proceed.call(this, vis, false); if (this.visible === false && this.ogl && this.canvas && this.image) { this.ogl.clear(); this.image.attr({ href: '' }); } else { this.chart.redraw(); } });

  2. I have set the boost module thresholds so high and indeed isSeiresBoosting or isChartSeriesBoosting both return false, and even then the boost wrap for setVisible keeps firing

@jberrydev

This comment has been minimized.

Show comment
Hide comment
@jberrydev

jberrydev Aug 24, 2017

This exists in 5.0.14 as well. Experiencing redraw with setVisible on series even with second false param. Any temporary work around?

jberrydev commented Aug 24, 2017

This exists in 5.0.14 as well. Experiencing redraw with setVisible on series even with second false param. Any temporary work around?

@jberrydev

This comment has been minimized.

Show comment
Hide comment
@jberrydev

jberrydev Aug 24, 2017

I just removed boost from my package and seems to have fixed the performance issues. Odd. Thanks for the good work though guys. I will check back for a fix.

jberrydev commented Aug 24, 2017

I just removed boost from my package and seems to have fixed the performance issues. Odd. Thanks for the good work though guys. I will check back for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment