New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setExtremes method issue for heatmap plot with boost module #6895

Closed
AndreiKoriagin opened this Issue Jun 23, 2017 · 4 comments

Comments

Projects
None yet
6 participants
@AndreiKoriagin

AndreiKoriagin commented Jun 23, 2017

There's problem with boost module when using setExtremes method.

Expected behaviour

rectangles with lower cathegory value are hidden.

Actual behaviour

rectangles with lower cathegory value are visible outside of plot area.

Live demo with steps to reproduce

http://jsfiddle.net/xs0z64ny/

Affected browser(s)

Chrome (Windows)

I reached expected behavior by changing line 2028 in boost.src.js (method createAndAttachRenderer):

target.boostClipRect.attr({
    x: chart.plotLeft,
    y: chart.plotTop,
    width: chart.plotWidth,
    height: chart.plotHeight //height: chart.chartHeight <- instead of this
});
@sebastianbochan

This comment has been minimized.

Show comment
Hide comment
@sebastianbochan

sebastianbochan Jun 26, 2017

Contributor

Thank you for the reporting.

It looks like the same issue as the: #6865

Contributor

sebastianbochan commented Jun 26, 2017

Thank you for the reporting.

It looks like the same issue as the: #6865

@yoderexploder

This comment has been minimized.

Show comment
Hide comment
@yoderexploder

yoderexploder Oct 30, 2017

I'm having this problem as well. Is there a current work around?

yoderexploder commented Oct 30, 2017

I'm having this problem as well. Is there a current work around?

@pawelfus pawelfus self-assigned this Oct 31, 2017

pawelfus added a commit that referenced this issue Oct 31, 2017

@pawelfus pawelfus removed their assignment Oct 31, 2017

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Nov 3, 2017

Collaborator

@cvasseng As far as I can see there's a potential room for optimizing in the createAndAttachRenderer function. This function runs 1200 times in the line-series-heavy-stock sample, one for each series. On each iteration, it runs function like boostClipRect.attr, boostResizeTarget and boostClear. When it renders to a chart-level canvas, this is repeated 600 times with the same parameters, which seems redundant.

Collaborator

TorsteinHonsi commented Nov 3, 2017

@cvasseng As far as I can see there's a potential room for optimizing in the createAndAttachRenderer function. This function runs 1200 times in the line-series-heavy-stock sample, one for each series. On each iteration, it runs function like boostClipRect.attr, boostResizeTarget and boostClear. When it renders to a chart-level canvas, this is repeated 600 times with the same parameters, which seems redundant.

@cvasseng

This comment has been minimized.

Show comment
Hide comment
@cvasseng

cvasseng Nov 6, 2017

Contributor

@TorsteinHonsi yes, there's some room for improvement there. It needs to be called for every series if not boosting on chart level, but the cliprect should only be set when the chart has reflowed, and when it's first initialized.

Contributor

cvasseng commented Nov 6, 2017

@TorsteinHonsi yes, there's some room for improvement there. It needs to be called for every series if not boosting on chart level, but the cliprect should only be set when the chart has reflowed, and when it's first initialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment