New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with large heatmap chart using boost module #6981

Closed
ff-tushar opened this Issue Jul 20, 2017 · 12 comments

Comments

Projects
None yet
5 participants
@ff-tushar

ff-tushar commented Jul 20, 2017

Expected behaviour

When we upgraded to the High Chart 5.0.11 we have used the Boost module for rendering the large Heatmap chart. It should render the chart properly with the colors we provide.

Actual behaviour

The heatmap chart does not draw properly. It does not plot the expected colors on the chart. Added question for the same on the High chart forum https://forum.highcharts.com/highcharts-usage/canvas-solution-for-long-heatmap-chart-t38375/

Live demo with steps to reproduce

template: http://jsfiddle.net/d_paul/ozv1to3t/
In the mentioned JSFiddle. We are seeing the issue that color plotted for the points are not correct.
If you mouse over on the blue point value is 70.13 and shows high lighting correctly on the legend but on chart it has plotted in blue color.
It looks like the plotting color for the point is wrong.

Affected browser(s)

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Jul 20, 2017

Contributor

Color does plot correctly, but it looks like tooltip is rendered for a wrong point. In your screenshot you can see in tooltip: 70.13 -> so it's correct color, but wrong point. Short gif:

v9agcquqaf

Contributor

pawelfus commented Jul 20, 2017

Color does plot correctly, but it looks like tooltip is rendered for a wrong point. In your screenshot you can see in tooltip: 70.13 -> so it's correct color, but wrong point. Short gif:

v9agcquqaf

@ff-tushar

This comment has been minimized.

Show comment
Hide comment
@ff-tushar

ff-tushar Jul 20, 2017

Please check the following JS Fiddle which behaves correctly which has same code but only difference is boost module is not included. You can see clear difference in the color plotted on charts with respect to mentioned JS Fiddle in issue.
Withput Boost Module:- https://jsfiddle.net/tushar412/mvk4c6e1/1/.
Also mentioned JSFiddle in the ticket if you mouse over on the chart with blue line you can see the legands over is on different color. Legand color is correct but chart plotting color is wrong.

ff-tushar commented Jul 20, 2017

Please check the following JS Fiddle which behaves correctly which has same code but only difference is boost module is not included. You can see clear difference in the color plotted on charts with respect to mentioned JS Fiddle in issue.
Withput Boost Module:- https://jsfiddle.net/tushar412/mvk4c6e1/1/.
Also mentioned JSFiddle in the ticket if you mouse over on the chart with blue line you can see the legands over is on different color. Legand color is correct but chart plotting color is wrong.

@cvasseng

This comment has been minimized.

Show comment
Hide comment
@cvasseng

cvasseng Jul 25, 2017

Contributor

Internal note: The issue is with inverted heatmaps. When removing inverted, the boosted and non-boosted fiddles are identical. Guessing it's a translation error. Update: the boosted version is rotated 180 degrees/flipped when inverted.

Contributor

cvasseng commented Jul 25, 2017

Internal note: The issue is with inverted heatmaps. When removing inverted, the boosted and non-boosted fiddles are identical. Guessing it's a translation error. Update: the boosted version is rotated 180 degrees/flipped when inverted.

@ff-tushar

This comment has been minimized.

Show comment
Hide comment
@ff-tushar

ff-tushar Jul 26, 2017

Is this scheduled for upcoming release? If yes, can you please share the same when this will be available.

ff-tushar commented Jul 26, 2017

Is this scheduled for upcoming release? If yes, can you please share the same when this will be available.

@ff-rboutotte

This comment has been minimized.

Show comment
Hide comment
@ff-rboutotte

ff-rboutotte Jul 26, 2017

We are also facing the same issue....do you have a fix we can apply before it is officially fixed? We have a release next week and this is a blocker for us due to performance of the chart, without the boost module it takes 2-3 times longer to render the chart.

ff-rboutotte commented Jul 26, 2017

We are also facing the same issue....do you have a fix we can apply before it is officially fixed? We have a release next week and this is a blocker for us due to performance of the chart, without the boost module it takes 2-3 times longer to render the chart.

@ff-cviradiya

This comment has been minimized.

Show comment
Hide comment
@ff-cviradiya

ff-cviradiya Jul 27, 2017

boost module is really making things faster. We are not able to include boost and take the performance benefit because of this issue. The fix for this would greatly help.

Please expedite this if possible.

ff-cviradiya commented Jul 27, 2017

boost module is really making things faster. We are not able to include boost and take the performance benefit because of this issue. The fix for this would greatly help.

Please expedite this if possible.

@cvasseng

This comment has been minimized.

Show comment
Hide comment
@cvasseng

cvasseng Jul 27, 2017

Contributor

This has now been fixed in the hc5-fixes branch (https://github.highcharts.com/hc5-fixes/modules/boost.js).

It will be merged into master for the next release, until then, you could copy the module from the hc5-fixes branch and use it that way.

Contributor

cvasseng commented Jul 27, 2017

This has now been fixed in the hc5-fixes branch (https://github.highcharts.com/hc5-fixes/modules/boost.js).

It will be merged into master for the next release, until then, you could copy the module from the hc5-fixes branch and use it that way.

@ff-tushar

This comment has been minimized.

Show comment
Hide comment
@ff-tushar

ff-tushar Jul 28, 2017

@TorsteinHonsi and @cvasseng
After updating the boost module code. This is not working in Chrome. We are getting
"Cannot create property 'moveTo' on boolean 'false'" JS error and due to that it does not render the chart.
Please Re-open this.

ff-tushar commented Jul 28, 2017

@TorsteinHonsi and @cvasseng
After updating the boost module code. This is not working in Chrome. We are getting
"Cannot create property 'moveTo' on boolean 'false'" JS error and due to that it does not render the chart.
Please Re-open this.

@cvasseng

This comment has been minimized.

Show comment
Hide comment
@cvasseng

cvasseng Jul 28, 2017

Contributor

@ff-tushar: I'm not seeing any errors in Chrome 59.0.3071.115 on macos.

Are you getting the error in this fiddle too?

Could you paste the console log (or post a screenshot)?

Contributor

cvasseng commented Jul 28, 2017

@ff-tushar: I'm not seeing any errors in Chrome 59.0.3071.115 on macos.

Are you getting the error in this fiddle too?

Could you paste the console log (or post a screenshot)?

@ff-tushar

This comment has been minimized.

Show comment
Hide comment
@ff-tushar

ff-tushar Jul 28, 2017

@cvasseng
After doing the investigation I have found that it does not work with the 5.0.12 version of High Chart.
Here is the JS Fiddle of for the same:- https://jsfiddle.net/tushar412/j10r66x8/3/
Do we have to upgrade to version 5.0.13?

ff-tushar commented Jul 28, 2017

@cvasseng
After doing the investigation I have found that it does not work with the 5.0.12 version of High Chart.
Here is the JS Fiddle of for the same:- https://jsfiddle.net/tushar412/j10r66x8/3/
Do we have to upgrade to version 5.0.13?

@cvasseng

This comment has been minimized.

Show comment
Hide comment
@cvasseng

cvasseng Jul 28, 2017

Contributor

An updated has been pushed to hc5-fixes now.

The fix will be included in 5.0.14 which is a hotfix release arriving later today.

Contributor

cvasseng commented Jul 28, 2017

An updated has been pushed to hc5-fixes now.

The fix will be included in 5.0.14 which is a hotfix release arriving later today.

@ff-tushar

This comment has been minimized.

Show comment
Hide comment
@ff-tushar

ff-tushar Jul 28, 2017

Let me try out.

ff-tushar commented Jul 28, 2017

Let me try out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment