New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error on writing new chart to a node that was originally detached. #7014

Closed
TorsteinHonsi opened this Issue Jul 28, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@TorsteinHonsi
Collaborator

TorsteinHonsi commented Jul 28, 2017

Live demo with steps to reproduce

http://jsfiddle.net/hxqz2unk/1/

Affected browser(s)

All

@TorsteinHonsi TorsteinHonsi added the Bug label Jul 28, 2017

@TorsteinHonsi TorsteinHonsi self-assigned this Jul 28, 2017

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Jul 28, 2017

Collaborator

Regression since 5800b1b

Collaborator

TorsteinHonsi commented Jul 28, 2017

Regression since 5800b1b

@tpeyrard

This comment has been minimized.

Show comment
Hide comment
@tpeyrard

tpeyrard Aug 9, 2017

Hi,

just to let you know that this fix c92a4d6 (or the 5800b1b) prevents users to use Highcharts in some Polymer elements because it plays with the DOM without taking into account the shadow doms...

It works fine with version 5.0.12.

tpeyrard commented Aug 9, 2017

Hi,

just to let you know that this fix c92a4d6 (or the 5800b1b) prevents users to use Highcharts in some Polymer elements because it plays with the DOM without taking into account the shadow doms...

It works fine with version 5.0.12.

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Aug 10, 2017

Collaborator

Thanks for letting us know! I'm not too familiar with Polymer, can you help me demonstrate the issue so we can find a workaround? I tried this... https://jsfiddle.net/highcharts/2q3fqehz/178/

Collaborator

TorsteinHonsi commented Aug 10, 2017

Thanks for letting us know! I'm not too familiar with Polymer, can you help me demonstrate the issue so we can find a workaround? I tried this... https://jsfiddle.net/highcharts/2q3fqehz/178/

@tpeyrard

This comment has been minimized.

Show comment
Hide comment
@tpeyrard

tpeyrard Aug 10, 2017

I edited the script. I got the error #13
https://jsfiddle.net/2q3fqehz/179/

I don't know whether it can be fixed at the Polymer level.

tpeyrard commented Aug 10, 2017

I edited the script. I got the error #13
https://jsfiddle.net/2q3fqehz/179/

I don't know whether it can be fixed at the Polymer level.

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Aug 10, 2017

Collaborator

Thanks, but that also fails with v5.0.12... https://jsfiddle.net/highcharts/2q3fqehz/180/

Collaborator

TorsteinHonsi commented Aug 10, 2017

Thanks, but that also fails with v5.0.12... https://jsfiddle.net/highcharts/2q3fqehz/180/

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Aug 10, 2017

Collaborator

Here's a demo with Shadow DOM without Polymer. It works with the latest Highcharts, v5.0.14: http://jsfiddle.net/highcharts/cjxjp9ok/

Collaborator

TorsteinHonsi commented Aug 10, 2017

Here's a demo with Shadow DOM without Polymer. It works with the latest Highcharts, v5.0.14: http://jsfiddle.net/highcharts/cjxjp9ok/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment