New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart does not destroy properly #7021

Closed
arthoul opened this Issue Jul 31, 2017 · 12 comments

Comments

Projects
None yet
7 participants
@arthoul

arthoul commented Jul 31, 2017

Expected behaviour

I want to be able to destroy a chart with an "areasplinerange" series and a "spline" one.

Actual behaviour

If I update range and then, destroy the chart, I get the following error:
"Cannot read property 'isSVG' of undefined"

Live demo with steps to reproduce

click on the "1m" button and then on "destroy chart"
http://jsfiddle.net/n2dy4xk3/2/

Affected browser(s)

all

@KacperMadej

This comment has been minimized.

Show comment
Hide comment
@KacperMadej

KacperMadej Jul 31, 2017

Contributor

@arthoul Please clear yours browser cache and try again - this error might happen when trying to use current / new Highcharts / Highstock with an exporting module in older version. I am unable to recreate the problem.

Contributor

KacperMadej commented Jul 31, 2017

@arthoul Please clear yours browser cache and try again - this error might happen when trying to use current / new Highcharts / Highstock with an exporting module in older version. I am unable to recreate the problem.

@arthoul

This comment has been minimized.

Show comment
Hide comment
@arthoul

arthoul Jul 31, 2017

Hi @KacperMadej ,
Same trouble with no cache enabled (tested on IE+Chrome on Windows 7 & Chrome on macos).
You cannot reproduce it with the jsfiddle ?

arthoul commented Jul 31, 2017

Hi @KacperMadej ,
Same trouble with no cache enabled (tested on IE+Chrome on Windows 7 & Chrome on macos).
You cannot reproduce it with the jsfiddle ?

@KacperMadej

This comment has been minimized.

Show comment
Hide comment
@KacperMadej

KacperMadej Jul 31, 2017

Contributor

@arthoul Tooltip had to be triggered at least once - I have recreate the problem. Thank you for your help and for reporting the problem.

Contributor

KacperMadej commented Jul 31, 2017

@arthoul Tooltip had to be triggered at least once - I have recreate the problem. Thank you for your help and for reporting the problem.

@KacperMadej KacperMadej self-assigned this Jul 31, 2017

@arthoul

This comment has been minimized.

Show comment
Hide comment
@arthoul

arthoul Jul 31, 2017

@KacperMadej you got it ! thank's to you

arthoul commented Jul 31, 2017

@KacperMadej you got it ! thank's to you

@KacperMadej

This comment has been minimized.

Show comment
Hide comment
@KacperMadej

KacperMadej Jul 31, 2017

Contributor

@arthoul The problem is fixed on hc5-fixes branch, so you could use that version of code until next official release (the issue will be closed when the commit will be included in next release candidate version of Highcharts) or wait for the next Highcharts version with the fix included.

Working demo: http://jsfiddle.net/n2dy4xk3/4/

Contributor

KacperMadej commented Jul 31, 2017

@arthoul The problem is fixed on hc5-fixes branch, so you could use that version of code until next official release (the issue will be closed when the commit will be included in next release candidate version of Highcharts) or wait for the next Highcharts version with the fix included.

Working demo: http://jsfiddle.net/n2dy4xk3/4/

@JDoro

This comment has been minimized.

Show comment
Hide comment
@JDoro

JDoro Sep 12, 2017

Is this getting merged any time soon?

JDoro commented Sep 12, 2017

Is this getting merged any time soon?

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Sep 13, 2017

Contributor

The fix is merged into master branch, that means it will be included in the next release.

Contributor

pawelfus commented Sep 13, 2017

The fix is merged into master branch, that means it will be included in the next release.

@JDoro

This comment has been minimized.

Show comment
Hide comment
@JDoro

JDoro Sep 13, 2017

Ah. I saw that the branch it was developed on was still out there and thought it hadn't been merged yet. Any idea when the next release will be?

JDoro commented Sep 13, 2017

Ah. I saw that the branch it was developed on was still out there and thought it hadn't been merged yet. Any idea when the next release will be?

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Sep 14, 2017

Collaborator

It will ship within a few weeks.

Here's a drop-in fix that you can use in the meantime:

Highcharts.wrap(
    Highcharts.seriesTypes.arearange.prototype.pointClass.prototype,
    'setState',
    function (proceed) {
        proceed.apply(this, Array.prototype.slice.call(arguments, 1));
    
        if (this.series.stateMarkerGraphic) {
    	    this.series.lowerStateMarkerGraphic = undefined;
        }
    }
);

View it live at http://jsfiddle.net/highcharts/n2dy4xk3/5/

Collaborator

TorsteinHonsi commented Sep 14, 2017

It will ship within a few weeks.

Here's a drop-in fix that you can use in the meantime:

Highcharts.wrap(
    Highcharts.seriesTypes.arearange.prototype.pointClass.prototype,
    'setState',
    function (proceed) {
        proceed.apply(this, Array.prototype.slice.call(arguments, 1));
    
        if (this.series.stateMarkerGraphic) {
    	    this.series.lowerStateMarkerGraphic = undefined;
        }
    }
);

View it live at http://jsfiddle.net/highcharts/n2dy4xk3/5/

@JDoro

This comment has been minimized.

Show comment
Hide comment
@JDoro

JDoro Sep 14, 2017

Awesome! This worked! Thanks!

JDoro commented Sep 14, 2017

Awesome! This worked! Thanks!

@dt-karl-kuhn

This comment has been minimized.

Show comment
Hide comment
@dt-karl-kuhn

dt-karl-kuhn Mar 1, 2018

Hi, what release is this included in?

dt-karl-kuhn commented Mar 1, 2018

Hi, what release is this included in?

@sebastianbochan

This comment has been minimized.

Show comment
Hide comment
@sebastianbochan

sebastianbochan Mar 1, 2018

Contributor

The issue is fixed since 6.0.0 version.

Change log: https://www.highcharts.com/documentation/changelog

Contributor

sebastianbochan commented Mar 1, 2018

The issue is fixed since 6.0.0 version.

Change log: https://www.highcharts.com/documentation/changelog

siosTomBeckenhauer added a commit to siosTomBeckenhauer/highcharts that referenced this issue Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment