New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export highcharts.scss file, please ! #7030

Closed
aedart opened this Issue Aug 2, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@aedart

aedart commented Aug 2, 2017

Hi

While it is nice that your bundle does include the highcharts.css, it would be really nice to be able to use your highcharts.scss, instead of having to manually copy it from your git.

The reason why it is a very good idea for you to start exporting this, is so that developers are able to just include it directly into their "master" scss file, as a bundle from which their can overwrite just the few properties that they need to.

@KacperMadej

This comment has been minimized.

Show comment
Hide comment
@KacperMadej

KacperMadej Aug 2, 2017

Contributor

Hi,

Thank you for posting your enhancement suggestion.

Just to make sure that all info is here:

Contributor

KacperMadej commented Aug 2, 2017

Hi,

Thank you for posting your enhancement suggestion.

Just to make sure that all info is here:

@aedart

This comment has been minimized.

Show comment
Hide comment
@aedart

aedart Aug 2, 2017

Hi KacperMadej

Yes, I am using npm for obtaining highcharts. Furthermore, I am creating my own custom bundle, where highcharts' "source" Javascript is just a small part of it.

Furthermore, I am also using .scss files, e.g. bootstrap, which I'm also building to a single file.
It would be great if you could include your scss file. It does not have to be to the css folder. Just where ever you find it to make the most sense.

aedart commented Aug 2, 2017

Hi KacperMadej

Yes, I am using npm for obtaining highcharts. Furthermore, I am creating my own custom bundle, where highcharts' "source" Javascript is just a small part of it.

Furthermore, I am also using .scss files, e.g. bootstrap, which I'm also building to a single file.
It would be great if you could include your scss file. It does not have to be to the css folder. Just where ever you find it to make the most sense.

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Aug 2, 2017

Collaborator

Thanks, that makes sense. Should be published to the zip file and the shim repos.

Collaborator

TorsteinHonsi commented Aug 2, 2017

Thanks, that makes sense. Should be published to the zip file and the shim repos.

jon-a-nygaard added a commit that referenced this issue Aug 3, 2017

@jon-a-nygaard jon-a-nygaard added this to the v5.0.15 milestone Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment