Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`minPointLength` doesn't work for zero value columns when all other columns have negative values #7046

Closed
hon2a opened this issue Aug 8, 2017 · 6 comments
Labels

Comments

@hon2a
Copy link

@hon2a hon2a commented Aug 8, 2017

Expected behaviour

When I create a bar/column chart with a single series that has only zero and negative values and set minPointLength to a positive value, the zero value bars/columns should show up with the height set in minPointLength.

Actual behaviour

The zero value bars/columns don't show up.

If at least one of the values is positive, however, it works as expected.

Live demo with steps to reproduce

See the demo.

Affected browser(s)

All.

@KacperMadej
Copy link
Contributor

@KacperMadej KacperMadej commented Aug 9, 2017

Hi,

Thank you for reporting about the bug.

Internal note: This is caused by minPointLength showing only as a positive value - see here: http://jsfiddle.net/4j1zgegw/2/

@KacperMadej KacperMadej self-assigned this Aug 9, 2017
KacperMadej added a commit that referenced this issue Aug 9, 2017
@KacperMadej
Copy link
Contributor

@KacperMadej KacperMadej commented Aug 23, 2017

Regression due to b914777.
The logic for the fix of this issue was relaying on series.dataMax being calculated only for visible range.
Demo: http://jsfiddle.net/4j1zgegw/3/

@KacperMadej KacperMadej reopened this Aug 23, 2017
@KacperMadej KacperMadej removed their assignment Aug 23, 2017
@Sphinxxxx
Copy link

@Sphinxxxx Sphinxxxx commented Oct 4, 2017

Not sure whether this is the same issue, but it shows the same behavior as the OP's demo: If the column chart has only negative values, nothing is rendered until you force a refresh, e.g. by resizing the window or hiding one of the series:

http://jsfiddle.net/dpnv7g2m/

@hon2a
Copy link
Author

@hon2a hon2a commented Oct 4, 2017

@Sphinxxxx: That's something different (and much more critical), so you should create a separate thread for it. This issue is concerned with the zero-value column rendering upwards (outside plot area) when used with non-zero minPointLength and when all other columns have negative values.

@Sphinxxxx
Copy link

@Sphinxxxx Sphinxxxx commented Oct 4, 2017

@hon2a Thanks, new issue here: #7228

@hon2a
Copy link
Author

@hon2a hon2a commented Oct 17, 2017

@KacperMadej: @TorsteinHonsi: I'm closing this as it seems to be working in 6.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants