New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when check installation using yarn #7115

Closed
StabbarN opened this Issue Aug 31, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@StabbarN

StabbarN commented Aug 31, 2017

Expected behaviour

yarn check should pass.

Actual behaviour

Live demo with steps to reproduce

In terminal:
yarn add highcharts

yarn check
gives output

yarn check v0.27.5
warning package.json: No license field
warning No license field
error "highcharts" is wrong version: expected "5.0.14", got "v5.0.14"
error Found 1 errors.
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.

Environment:
yarn 0.27.5
npm 5.3.0
node 8.4.0
macOS 10.12.6

https://github.com/highcharts/highcharts/blob/master/package.json ("version": "5.0.14",) has no "v" added to the version string

https://github.com/highcharts/highcharts-dist/blob/master/package.json ("version": "v5.0.14",) has a "v" added to the version string.

Remove "v" from line "version": "v5.0.14", in package.json from highcharts-dist.
The repo highcarts-dist has no issues list on github so I'm creating the issue on this repo instead. I hope the correct people notices this ( @TorsteinHonsi seems to do the releases) .

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Aug 31, 2017

Collaborator

Thanks! It will be corrected by the next minor release.

Collaborator

TorsteinHonsi commented Aug 31, 2017

Thanks! It will be corrected by the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment