New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend box is not being resized when dynamically adding/removing series #7260

Closed
YusselPP opened this Issue Oct 11, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@YusselPP

YusselPP commented Oct 11, 2017

Expected behaviour

Adjust legend box size when dynamically adding or removing series.

Note: Before version 6 this was the behaviour

Actual behaviour

The legend box doesn't change its size when series are added or removed.

Live demo with steps to reproduce

See demo.

Affected browser(s)

All.

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Oct 12, 2017

Contributor

Hi @YusselPP

Thank you for reporting the issue! It looks like a regression after c4fef24 commit.

Contributor

pawelfus commented Oct 12, 2017

Hi @YusselPP

Thank you for reporting the issue! It looks like a regression after c4fef24 commit.

@pawelfus pawelfus added the Regression label Oct 12, 2017

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Oct 13, 2017

Collaborator

The bug comes down to SVGRenderer.crisp, that is called when animating the box. It alters the wrapper cached value of the properies, so when the animators try to read them, they are already set to the animation target, and the to === from test accidentally passes.

Collaborator

TorsteinHonsi commented Oct 13, 2017

The bug comes down to SVGRenderer.crisp, that is called when animating the box. It alters the wrapper cached value of the properies, so when the animators try to read them, they are already set to the animation target, and the to === from test accidentally passes.

@TorsteinHonsi TorsteinHonsi self-assigned this Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment