New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data module: endRow is cutting off last row of data #7265

Closed
KacperMadej opened this Issue Oct 12, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@KacperMadej
Contributor

KacperMadej commented Oct 12, 2017

Expected behaviour

When endRow is set to e.g. 2, then 3th row of data should be used (because indexed from 0, as explained in API docs).

Actual behaviour

When endRow is set to 2 then 1st row is the last used data row.

Live demo with steps to reproduce

http://jsfiddle.net/BlackLabel/hr6j17eq/

@KacperMadej KacperMadej added the Bug label Oct 12, 2017

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Oct 13, 2017

Collaborator

It's a regression, it worked in v5: http://jsfiddle.net/hr6j17eq/1/

Collaborator

TorsteinHonsi commented Oct 13, 2017

It's a regression, it worked in v5: http://jsfiddle.net/hr6j17eq/1/

@cvasseng

This comment has been minimized.

Show comment
Hide comment
@cvasseng

cvasseng Oct 13, 2017

Contributor

Sorry, I misread, looked like you referenced the other issue, so I fixed this too. Same solution though, so should merge fine.

Contributor

cvasseng commented Oct 13, 2017

Sorry, I misread, looked like you referenced the other issue, so I fixed this too. Same solution though, so should merge fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment