New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinity value breaks Heatmap #7394

Closed
chabb opened this Issue Nov 12, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@chabb

chabb commented Nov 12, 2017

There are some solutions to handle those Infinity value, but i think the default behaviour can be better. Right now, it breaks the legend, and all cells are black

Live demo with steps to reproduce

https://jsfiddle.net/chab/4aqhB/1091/

Affected browser(s)

All

@chabb chabb closed this Nov 12, 2017

@chabb chabb reopened this Nov 12, 2017

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Nov 13, 2017

Contributor

Thank you for your suggestion.

Contributor

pawelfus commented Nov 13, 2017

Thank you for your suggestion.

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Nov 15, 2017

Collaborator

Related to #3571 (comment). I'll add a check for Infinity and -Infinity in the isNumber function, it doesn't seem to affect performance.

Collaborator

TorsteinHonsi commented Nov 15, 2017

Related to #3571 (comment). I'll add a check for Infinity and -Infinity in the isNumber function, it doesn't seem to affect performance.

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi
Collaborator

TorsteinHonsi commented Nov 15, 2017

Demo with the fix applied: https://jsfiddle.net/highcharts/4aqhB/1095/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment