New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart axis disappear, when navigator is exercised, after disabling of series #7411

Closed
mynameiswhat1 opened this Issue Nov 16, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@mynameiswhat1

mynameiswhat1 commented Nov 16, 2017

Expected behaviour

Chart axis should not disappear due to a navigator change

Actual behaviour

Chart axis disappear, when navigator is exercised, after disabling of series.

Live demo with steps to reproduce

http://jsfiddle.net/um1s8k7n/

  • Move leftmost limit of navigator inwards;
  • Move rightmost limit of navigator inwards;
  • Disable series 1 by clicking on it's name in chart legend;
  • Disable series 2 by clicking on it's name in chart legend;
  • Move rightmost limit of navigator inwards;

Result: the axis disappear after navigator is moved. By looking at highstock code, it seems that the issue might be related with the redraw of the chart.

noaxis

Affected browser(s)

62.0.3202.94 (Official Build) (64 bits)

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Nov 16, 2017

Contributor

Hi @mynameiswhat1

Thank you, once again, for reporting an issue. It looks like connected navigator series is hidden with main series - that may cause the issue (no visible series on the chart). Using a separate series for the navigator, we can workaround the issue: http://jsfiddle.net/um1s8k7n/1/

It used to work in 5.0.12: http://jsfiddle.net/um1s8k7n/2/

Internal note:
Regression after 15aad0d

Contributor

pawelfus commented Nov 16, 2017

Hi @mynameiswhat1

Thank you, once again, for reporting an issue. It looks like connected navigator series is hidden with main series - that may cause the issue (no visible series on the chart). Using a separate series for the navigator, we can workaround the issue: http://jsfiddle.net/um1s8k7n/1/

It used to work in 5.0.12: http://jsfiddle.net/um1s8k7n/2/

Internal note:
Regression after 15aad0d

@mynameiswhat1

This comment has been minimized.

Show comment
Hide comment
@mynameiswhat1

mynameiswhat1 Nov 16, 2017

Hello @pawelfus,
Thank you for the quick response. Unfortunatelly, the workaround you have sugested will not work for us, since we need to be able to show all the chart's series in the navigator and be able to infer them from the series.
Will this be corrected in a future release?
Thank you very much.

mynameiswhat1 commented Nov 16, 2017

Hello @pawelfus,
Thank you for the quick response. Unfortunatelly, the workaround you have sugested will not work for us, since we need to be able to show all the chart's series in the navigator and be able to infer them from the series.
Will this be corrected in a future release?
Thank you very much.

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Nov 17, 2017

Contributor

Hi @mynameiswhat1

Thank you for the details. I created simple drop-in fix for the current version:

  (function(H) {
    H.wrap(H.Series.prototype, 'setVisible', function(p, vis, redraw) {
      if (this.xAxis.options.className !== 'highcharts-navigator-xaxis') {
        p.call(this, vis, redraw);
      }
    });
  })(Highcharts);

It simply prevents series in navigator from being hidden: http://jsfiddle.net/um1s8k7n/4/

Of course, we need to fix this issue in the core.

Contributor

pawelfus commented Nov 17, 2017

Hi @mynameiswhat1

Thank you for the details. I created simple drop-in fix for the current version:

  (function(H) {
    H.wrap(H.Series.prototype, 'setVisible', function(p, vis, redraw) {
      if (this.xAxis.options.className !== 'highcharts-navigator-xaxis') {
        p.call(this, vis, redraw);
      }
    });
  })(Highcharts);

It simply prevents series in navigator from being hidden: http://jsfiddle.net/um1s8k7n/4/

Of course, we need to fix this issue in the core.

@mynameiswhat1

This comment has been minimized.

Show comment
Hide comment
@mynameiswhat1

mynameiswhat1 Nov 17, 2017

Hello @pawelfus,
Please, let me know when the fix is available in the core.
Thank you very much.

mynameiswhat1 commented Nov 17, 2017

Hello @pawelfus,
Please, let me know when the fix is available in the core.
Thank you very much.

@oysteinmoseng

This comment has been minimized.

Show comment
Hide comment
@oysteinmoseng

oysteinmoseng Dec 4, 2017

Collaborator

The hiding of the navigator series being linked with the base series is by design, and a new feature. The axis should not disappear when using the navigator with no visible series, though. Also, if you try to re-enable a series after the axis disappears, it fails.

Collaborator

oysteinmoseng commented Dec 4, 2017

The hiding of the navigator series being linked with the base series is by design, and a new feature. The axis should not disappear when using the navigator with no visible series, though. Also, if you try to re-enable a series after the axis disappears, it fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment