New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followTouchMove doesn't work properly on column series (mobile browser only) #7484

Closed
kamilkulig opened this Issue Dec 4, 2017 · 19 comments

Comments

Projects
None yet
7 participants
@kamilkulig
Contributor

kamilkulig commented Dec 4, 2017

Expected behaviour

Tooltip should always appear on the column under the pointer when followTouchMove is set to true.

Actual behavior

Sometimes tooltip remains in its previous position instead of following the drag movement (see the gif below).

followtouchmove -test

Live demo with steps to reproduce

Try to perform few drag moves like on the gif above.
http://jsfiddle.net/kkulig/njjuk9ke/

Reproduced on:

Chrome 62.0.3202.84
Android 6.0.1

@razmaimon

This comment has been minimized.

Show comment
Hide comment
@razmaimon

razmaimon commented Dec 4, 2017

@KacperMadej KacperMadej added the Bug label Dec 5, 2017

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Dec 8, 2017

Collaborator

Steps to reproduce:

  1. Open http://jsfiddle.net/highcharts/njjuk9ke/6/show in Chrome with mobile device emulation enabled.
  2. Tag on a column and drag.
Collaborator

TorsteinHonsi commented Dec 8, 2017

Steps to reproduce:

  1. Open http://jsfiddle.net/highcharts/njjuk9ke/6/show in Chrome with mobile device emulation enabled.
  2. Tag on a column and drag.
@skuske

This comment has been minimized.

Show comment
Hide comment
@skuske

skuske Mar 26, 2018

@TorsteinHonsi

Any timeframe when this will be fixed?

skuske commented Mar 26, 2018

@TorsteinHonsi

Any timeframe when this will be fixed?

@skuske

This comment has been minimized.

Show comment
Hide comment
@skuske

skuske commented Jun 21, 2018

@TorsteinHonsi

Any update, please! Thanks.

highcharts/highcharts-ios#70

@jon-a-nygaard

This comment has been minimized.

Show comment
Hide comment
@jon-a-nygaard

jon-a-nygaard Jul 3, 2018

Collaborator

This issue is fixed in pull request #8567, and will be included in an upcoming maintenance release.

Collaborator

jon-a-nygaard commented Jul 3, 2018

This issue is fixed in pull request #8567, and will be included in an upcoming maintenance release.

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Sep 17, 2018

Contributor

OP demo is still broken: http://jsfiddle.net/kkulig/njjuk9ke/ - tooltip follows pointer, but it's not updated when hovering other column. @jon-a-nygaard

Contributor

pawelfus commented Sep 17, 2018

OP demo is still broken: http://jsfiddle.net/kkulig/njjuk9ke/ - tooltip follows pointer, but it's not updated when hovering other column. @jon-a-nygaard

@skuske

This comment has been minimized.

Show comment
Hide comment
@skuske

skuske Sep 20, 2018

@pawelfus , @jon-a-nygaard , @TorsteinHonsi

When can we expect this to be fixed? We are waiting for months now, and the recent iOS wrapper which includes v6.1.2 actually made things even worse:

highcharts/highcharts-ios#129

skuske commented Sep 20, 2018

@pawelfus , @jon-a-nygaard , @TorsteinHonsi

When can we expect this to be fixed? We are waiting for months now, and the recent iOS wrapper which includes v6.1.2 actually made things even worse:

highcharts/highcharts-ios#129

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Sep 20, 2018

Collaborator

@skuske Thanks for your patience, we'll prioritize this.

A little recap for the buggy behaviour in v6.1.3. See http://jsfiddle.net/highcharts/njjuk9ke/16/.

  1. When touching the white area (outside column, the tooltip follows touch move and gets updated, even when touch-moving across columns.
  2. When touching the columns, the tooltip contents get stuck with the touched column, and the touched column receives hover color, but the tooltip moves along with the touch.
  3. Once we have touched a column, we cannot go back to situation 1. The next time we touch outside the columns, the closest column is highlighted and we're back to situation 2.
Collaborator

TorsteinHonsi commented Sep 20, 2018

@skuske Thanks for your patience, we'll prioritize this.

A little recap for the buggy behaviour in v6.1.3. See http://jsfiddle.net/highcharts/njjuk9ke/16/.

  1. When touching the white area (outside column, the tooltip follows touch move and gets updated, even when touch-moving across columns.
  2. When touching the columns, the tooltip contents get stuck with the touched column, and the touched column receives hover color, but the tooltip moves along with the touch.
  3. Once we have touched a column, we cannot go back to situation 1. The next time we touch outside the columns, the closest column is highlighted and we're back to situation 2.
@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi
Collaborator

TorsteinHonsi commented Sep 20, 2018

@skuske

This comment has been minimized.

Show comment
Hide comment
@skuske

skuske Sep 20, 2018

@TorsteinHonsi

Any chance that we can get the iOS wrapper updated with that fix? Many thanks in advance!

skuske commented Sep 20, 2018

@TorsteinHonsi

Any chance that we can get the iOS wrapper updated with that fix? Many thanks in advance!

@KacperMadej

This comment has been minimized.

Show comment
Hide comment
@KacperMadej

KacperMadej Sep 20, 2018

Contributor

@skuske The fix will be a part of the next code release, so it should be also available in corresponding wrapper for iOS release.

Contributor

KacperMadej commented Sep 20, 2018

@skuske The fix will be a part of the next code release, so it should be also available in corresponding wrapper for iOS release.

@skuske

This comment has been minimized.

Show comment
Hide comment
@skuske

skuske Sep 20, 2018

@KacperMadej

OK, that means that we do have to wait another two months for the next iOS wrapper update?

skuske commented Sep 20, 2018

@KacperMadej

OK, that means that we do have to wait another two months for the next iOS wrapper update?

@KacperMadej

This comment has been minimized.

Show comment
Hide comment
@KacperMadej

KacperMadej Sep 20, 2018

Contributor

@skuske

No, we do not have ETA for next release and iOS wrapper is usually updated up to few days after Highcharts release.

@TorsteinHonsi Do we have ETA for this fix to go live?

Contributor

KacperMadej commented Sep 20, 2018

@skuske

No, we do not have ETA for next release and iOS wrapper is usually updated up to few days after Highcharts release.

@TorsteinHonsi Do we have ETA for this fix to go live?

TorsteinHonsi added a commit that referenced this issue Sep 21, 2018

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Sep 21, 2018

Collaborator

I realized this still doesn't work so it is supposed. I did another commit, see http://jsfiddle.net/highcharts/42m90Lso/show.

The default settings are that followPointer is false and followTouchMove is true. This means that the tooltip should be updated as the finger moves across the plot area, but as the followPointer is false, it should point to the top of the columns, not stick to the finger.

@skuske I consider this a critical regression since all charts are buggy by default on all touch devices with the current version. Will immediately start the release process for a maintenance fix.

Collaborator

TorsteinHonsi commented Sep 21, 2018

I realized this still doesn't work so it is supposed. I did another commit, see http://jsfiddle.net/highcharts/42m90Lso/show.

The default settings are that followPointer is false and followTouchMove is true. This means that the tooltip should be updated as the finger moves across the plot area, but as the followPointer is false, it should point to the top of the columns, not stick to the finger.

@skuske I consider this a critical regression since all charts are buggy by default on all touch devices with the current version. Will immediately start the release process for a maintenance fix.

@skuske

This comment has been minimized.

Show comment
Hide comment
@skuske

skuske Sep 21, 2018

@TorsteinHonsi

Thanks for the update. Looking forward to the final fix for that. :o)

skuske commented Sep 21, 2018

@TorsteinHonsi

Thanks for the update. Looking forward to the final fix for that. :o)

@skuske

This comment has been minimized.

Show comment
Hide comment
@skuske

skuske Sep 26, 2018

@TorsteinHonsi

Does 6.1.4 fix this?

skuske commented Sep 26, 2018

@TorsteinHonsi

Does 6.1.4 fix this?

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Sep 27, 2018

Collaborator

Yes it does.

Collaborator

TorsteinHonsi commented Sep 27, 2018

Yes it does.

@skuske

This comment has been minimized.

Show comment
Hide comment
@skuske

skuske Sep 27, 2018

@TorsteinHonsi

Cool. When will the iOS wrapper be updated accordingly?

skuske commented Sep 27, 2018

@TorsteinHonsi

Cool. When will the iOS wrapper be updated accordingly?

@pawelfus

This comment has been minimized.

Show comment
Hide comment
@pawelfus

pawelfus Sep 27, 2018

Contributor

@skuske We will release iOS wrapper ASAP.

Answered: highcharts/highcharts-ios#129 (comment)

Contributor

pawelfus commented Sep 27, 2018

@skuske We will release iOS wrapper ASAP.

Answered: highcharts/highcharts-ios#129 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment