New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility of sankey and no-data-to-display modules #7489

Closed
Shiro00000 opened this Issue Dec 5, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Shiro00000

Shiro00000 commented Dec 5, 2017

Expected behaviour

if a sankey diagram is displayed, there should not be shown "no data to display"

Actual behaviour

"no data to display" is always displayed, no matter if a sankey diagram is shown or not
if another series is added no-data-to-display works correct. it seems to just ignore the sankey-diagram

Live demo with steps to reproduce

http://jsfiddle.net/L8vs4dsf/

just hang in both modules and insert a sankey-diagram

Affected browser(s)

tested in google chrome
sankeyshownodata

@KacperMadej

This comment has been minimized.

Show comment
Hide comment
@KacperMadej

KacperMadej Dec 5, 2017

Contributor

Hi,

Thank you for reporting about the bug.

Internal note: snakey doesn't have dataMin nor dataMax set, so it's recognized by the no-data-to-display as an empty:

H.Series.prototype.hasData = function () {
return this.visible && this.dataMax !== undefined && this.dataMin !== undefined; // #3703
};

Contributor

KacperMadej commented Dec 5, 2017

Hi,

Thank you for reporting about the bug.

Internal note: snakey doesn't have dataMin nor dataMax set, so it's recognized by the no-data-to-display as an empty:

H.Series.prototype.hasData = function () {
return this.visible && this.dataMax !== undefined && this.dataMin !== undefined; // #3703
};

@KacperMadej KacperMadej added the Bug label Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment