New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled mode annotations not working #7669

Closed
angelpcadena opened this Issue Jan 15, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@angelpcadena

angelpcadena commented Jan 15, 2018

When trying to use Annotations.js in Styled mode, it gives the error:
Uncaught TypeError: d.attr(...).css(...).shadow is not a function at f.Annotation.initLabel

Example: http://jsfiddle.net/og4o7p9L/

@pawelfus

This comment has been minimized.

Contributor

pawelfus commented Jan 16, 2018

Hi @angelpcadena

Thank you for reporting this issue.

morganfree added a commit that referenced this issue Jan 24, 2018

Addition to #2d052fb, #7669, defining annotations markers was not con…
…sistent with defining defs in styled mode.
@morganfree

This comment has been minimized.

Contributor

morganfree commented Jan 24, 2018

@TorsteinHonsi

Styled mode also affects defining markers in annotations - jsFiddle. I have made a PR which should resolved the issue - defining markers will be more consistent with defining other defs in styled mode - jsFiddle.

TorsteinHonsi added a commit that referenced this issue Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment