Array indexOf Polyfill error in oldie module

[zhy1stgg]

Array indexOf Polyfill in your modules/oldie.src.js

if (!Array.prototype.indexOf) {
    H.indexOfPolyfill = function(arr) {
        var len,
            i = 0;

        if (arr) {
            len = arr.length;

            for (; i < len; i++) {
                if (arr[i] === this) {
                    return i;
                }
            }
        }

        return -1;
    };
}

fixed with:

if (!Array.prototype.indexOf) {
    H.indexOfPolyfill = function(item) {
        var len,
            i = 0;

        if (item) {
            len = this.length;

            for (; i < len; i++) {
                if (this[i] === item) {
                    return i;
                }
            }
        }

        return -1;
    };
}

[sebastianbochan]

Hi @zhy1stgg
Thank you for the suggestion.

@TorsteinHonsi does it make sense for you too?

[KacperMadej]

Internal note:

Additionally, H.indexOfPolyfill

highcharts/js/modules/oldie.src.js

Lines 107 to 124 in 88e8c48

	if (!Array.prototype.indexOf) {
	H.indexOfPolyfill = function (arr) {
	var len,
	i = 0;
	if (arr) {
	len = arr.length;
	for (; i < len; i++) {
	if (arr[i] === this) {
	return i;
	}
	}
	}
	return -1;
	};
	}

doesn't support fromIndex.

highcharts/js/parts/Utilities.js

Lines 1469 to 1474 in f47dfac

	H.inArray = function (item, arr, fromIndex) {
	return (
	H.indexOfPolyfill ||
	Array.prototype.indexOf
	).call(arr, item, fromIndex);
	};