New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null matrix positioning bug #8456

Closed
hoshmn opened this Issue Jun 11, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@hoshmn

hoshmn commented Jun 11, 2018

Hi there,

Is there a need to set this null here? We wrote a plugin to enable images to be used as axis labels, but this was causing them to be positioned in the upper left of the chart, despite position also including the appropriate x and y coords (in fact, this would occur even with matrix: undefined). Is there a reason to set this at all (/a reason the SVG renderer--or whatever is positioning elements--should be checking whether position has the property matrix rather than checking that the value isn't nil?)?

We worked around this with another plugin to delete the property, but making fix3dPosition a prototype method (and therefore wrappable) would also be nice.

It's difficult to provide repro steps or a demo because this only affected the positioning of images--text labels were not mis-positioned due to the matrix: null setting.

Thanks,
Josh

projected.matrix = null;

@KacperMadej

This comment has been minimized.

Contributor

KacperMadej commented Jun 12, 2018

Hi @hoshmn

Thank you for reporting about the issue.

We can run tests and check is a suggested solution / change will work and won't break anything. Just to be on the same page - delete projected.matrix instead of projected.matrix = null is what you are looking for?

@hoshmn

This comment has been minimized.

hoshmn commented Jun 12, 2018

Actually simpler than that, you could just remove the else case of setting projected.matrix = null entirely--projected does not have a matrix property at that point, so there's no need to delete it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment